Repository navigation
Pin the browser integration test job to ubuntu-24.04 - #1454
Merged
Merged
Conversation
GitHub moved ubuntu-latest to 26.04, and `playwright install --with-deps chromium` now fails with "Playwright does not support chromium on ubuntu26.04-x64". No browser is installed, so every Playwright test fails in a few milliseconds. Runs on 2026-10-26 passed; the first runs on 2026-10-27 failed on every branch. Pin only this job. The other integration jobs do not drive a browser, and the Axum job gets Chrome through browser-actions/setup-chrome, which works on the newer image. Unpin once the pinned Playwright version supports it.
aram356
requested review from
ChristianPavilonis,
dhruv8sh and
prk-Jr
and removed request for
ChristianPavilonis
October 27, 2026 05:17
prk-Jr
approved these changes
Oct 27, 2026
5 tasks done
prk-Jr
added a commit
that referenced
this pull request
Oct 27, 2026
Resolve the conflicts with #1222, #1290, #1413 and #1454 semantically: - Apply #1413's request-host validation to every selected source except the authenticated forwarder, including ingress and adapter runtime origin, and keep RequestInfo::from_request fallible. - Carry trace_bootstrap through #1290's async EOF driver so trace-active documents keep their bootstrap on that path. - Move the trace auth log test onto #1222's shared WarningCapture so the two test loggers no longer race for the process-global slot. - Adapt main's tests that relied on unauthenticated forwarded headers, and rewrite main's host-selection CHANGELOG entry to the merged order.
prk-Jr
added a commit
that referenced
this pull request
Oct 27, 2026
The ubuntu-latest image moved to 26.04, where Playwright cannot install chromium. Apply the same pin #1454 gave the browser integration tests job.
jwrosewell
pushed a commit
to jwrosewell/trusted-server
that referenced
this pull request
Oct 28, 2026
GitHub moved ubuntu-latest to 26.04, and `playwright install --with-deps chromium` now fails with "Playwright does not support chromium on ubuntu26.04-x64". No browser is installed, so every Playwright test fails in a few milliseconds. Runs on 2026-10-26 passed; the first runs on 2026-10-27 failed on every branch. Pin only this job. The other integration jobs do not drive a browser, and the Axum job gets Chrome through browser-actions/setup-chrome, which works on the newer image. Unpin once the pinned Playwright version supports it. (cherry picked from commit fd2bf10)
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ubuntu-latestmoved to 26.04, andplaywright install --with-deps chromiumnow fails:No browser gets installed, so every Playwright test then fails in a few milliseconds. This is repo-wide and not specific to any branch: the
browser integration testscheck passed on runs from 2026-10-26 and fails on the first runs from 2026-10-27, withImage: ubuntu-26.04in the job log.Found while CI was red on #1300; the failure is unrelated to that PR's changes, so the fix is here rather than mixed into it.
What changed
Pin only the
browser-testsjob toubuntu-24.04.The other jobs are deliberately left floating:
integration tests,integration tests (Fastly EC lifecycle), andprepare integration artifactsdo not drive a browser.cargo test (axum native)does use Chrome, but obtains it throughbrowser-actions/setup-chrome, which works on 26.04. Verified: on the same 26.04 run where the browser job failed, that job passed.Testing
actionlint .github/workflows/integration-tests.ymlpasses.runs-onchanges; the other three stayubuntu-latest.browser integration testsrun, which exercises the pinned image.Unpin once the pinned Playwright version supports the newer image.