Repository navigation
Move the loading cache module to the released caching crate - #1372
Open
jwrosewell wants to merge 40 commits into
Open
jwrosewell wants to merge 40 commits into
jwrosewell wants to merge 40 commits into
Conversation
The published pre-release the module was pinned at is superseded by the released 4.5.8, so the module reads `^4.5.8` and the lock file names it. Nothing else changes.
# Conflicts: # Cargo.toml
This was referenced Oct 15, 2026
fiftyone-caching moves from 4.5.8 to 4.5.13 in the root manifest and in the lock. The two published crates hold the same README.md and the same files under src/ and tests/, so nothing else moves.
This was referenced Oct 28, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Cargo.lockCargo.tomlCloses
Part of #1282, which the loading cache module's pull request (#1365) closes.
Spec
Spec: Not a feature, a dependency update. The loading cache module's design is loading-cache.
Test plan
CI on this pull request at becadbb passed all 20 checks.
cargo test-fastly && cargo test-axumcargo clippy-fastly && cargo clippy-axumcargo fmt --all -- --checkcd crates/trusted-server-js/lib && npx vitest runcd crates/trusted-server-js/lib && npm run formatcd docs && npm run formatcargo build --package trusted-server-adapter-fastly --release --target wasm32-wasip1fastly compute serveChecklist
unwrap()in production code (clippy deniesunwrap_usedin CI)logmacros as AGENTS.md asks (notprintln!)Stacks on the Google tag module (#1371).
What changed after the 51Degrees PR review
Dependency update
fiftyone-cachingon from the release 4.5.8, which this pull request pinned before, to 4.5.13 inCargo.tomlandCargo.lock, and nothing else changes, because 4.5.13, which 51Degrees released on 27 October, has the same source as 4.5.8.Kept current
mainat 7aa5c99 and the changes made lower in the stack.What this pull request does
fiftyone-cachingmoves from the pre-release4.5.8-49to the release4.5.13in the root manifest and in the lock. The crate's source is the same at both versions, so nothing else moves. James Rogers's review on the fork approved the move to the release4.5.8. The move on to4.5.13, which 51Degrees released on 27 October with the same source as4.5.8, was made after that review. The pin was placed by the loading cache module (#1365) when no release carried the crate.References #1282.