Skip to content

Limit the events sitemap to upcoming and recently ended events - #1446

Merged
daveearley merged 2 commits into
developfrom
feature/sitemap-recent-events
Oct 25, 2026
Merged

daveearley merged 2 commits into
developfrom
feature/sitemap-recent-events

Conversation

@daveearley

Copy link
Copy Markdown
Contributor

Summary

Sitemap

  • The events sitemap now lists an event only if it is live, allows indexing, and has a non-cancelled occurrence that is upcoming or ended within the last 120 days. Previously every live event stayed in it forever.
  • Events with no occurrences and fully cancelled events are left out.
  • changefreq and priority are removed from the event and organizer sitemaps. The event values came from the rollback-only events.start_date, which the query never selected, so every event was weekly / 0.5. Search engines ignore both tags.
  • The sitemap index page count uses the same query, so the pages stay consistent. Sitemaps are cached for an hour, so production switches over within an hour of deploying.

Unrelated: recurring schedule drawer

  • A schedule generated through the API can store range.until with a time. The schedule drawer now trims it to the date so editing the schedule works. New e2e spec covers it.
  • Ignore the local .cloudflare/ directory.

Testing

  • New Feature tests for the sitemap query: upcoming, ended within 120 days, ended over 120 days ago, cancelled, no occurrences, draft, indexing off, and count matching the listing.
  • Unit, Feature and Pint pass; frontend and e2e tsc clean.
  • recurring-occurrences.spec.ts passes on the dev stack (8/8).
  • /api/public/sitemap-events-1.xml on the dev stack returns the new XML.

The sitemap listed every live, indexable event forever, so years of ended
ticket pages crowded out new ones. Events now appear only while they have a
non-cancelled occurrence that is upcoming or ended within the last 120 days;
events with no occurrences are left out.

Also drop changefreq and priority from the sitemaps. The event values were
derived from the rollback-only events.start_date, which the query never
selected, so every event was marked weekly / 0.5. Search engines ignore both
tags anyway.
A schedule generated through the API can store range.until with a time
(2026-11-20T23:59:00). The schedule drawer passed that straight to the date
input, which broke the drawer when editing the schedule. Trim it to the date.

Also ignore the local .cloudflare/ directory.
@github-actions

Copy link
Copy Markdown
Contributor

✅ E2E smoke tests: Everything passed.

Mode Result ✅ Passed ❌ Failed ⚠️ Flaky ⏭️ Skipped ⏱️ Duration
Self-hosted ✅ Passed 111 0 0 0 2m 35s

Open the run

@daveearley
daveearley merged commit 2d52b30 into develop Oct 25, 2026
9 checks passed
@daveearley
daveearley deleted the feature/sitemap-recent-events branch October 25, 2026 07:54
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant