Repository navigation
Dvm concurrency amelioration - #264
Conversation
…ting to previous behavior. Moreover, the URI is only on the first line.
…ved file handling
…elease/IPS-framework into dvm-concurrency-amelioration
| # writes the URI to a file, and we need to read it to get the | ||
| # URI. We wait for the file to be created and for the URI to be | ||
| # written to it. We wait up to 30 seconds for this | ||
| deadline = time.monotonic() + 30 |
There was a problem hiding this comment.
good catch on time.monotonic(), I might have to refactor some of my code to use this
There was a problem hiding this comment.
This was yet another instance of "I didn't know to know" courtesy of the LLM. To me, that's one of the best unexpected benefits of using those tools is learning of concepts or tools that I needed to know, or are otherwise useful, but didn't.
Lance-Drane
left a comment
Lance-Drane
left a comment
There was a problem hiding this comment.
LGTM, might need to run this through the formatter/linter and add a couple of typing checks but that's no reason to block
| class _DVMDiagnostics: | ||
| """Worker-local, thread-safe lifecycle journal; constructed after plugin transfer.""" | ||
|
|
||
| def __init__(self, directory, worker): |
There was a problem hiding this comment.
might be nice to add types here (Path and Worker should already be imported)
| environment={ | ||
| key: os.environ[key] | ||
| for key in ( | ||
| 'SLURM_JOB_ID', 'SLURM_JOB_NODELIST', 'SLURM_JOB_NUM_NODES', | ||
| 'PRTE_MCA_ras_slurm_use_entire_allocation', | ||
| 'PRTE_MCA_rmaps_default_mapping_policy', | ||
| ) | ||
| if key in os.environ | ||
| }, |
There was a problem hiding this comment.
optional consideration: do you think it might be useful to just greedily record every environment variable which starts with SLURM_ or PRTE_ ?
This incorporates @Lance-Drane 's fixes that were on the 0.9.0-prerelease branch and adds copious DVM related logging. I also made some minor changes to the examples yet again to convey that they examples when viewed on the portal.