Repository navigation
DVM hardening and logging - #261
Merged
Merged
Conversation
do not write prte's stdout to a pipe, write it to a unique log file instead strip the newline when reading the DVM URI WARNING: ensemble summary can hide failures in subcomponents Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
… for example 023 to be a little more consistent with other examples and to emphasize that that is an instance directory
…nstance hostname resolution
…tomatic hostname detection
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
markcoletti
approved these changes
Oct 22, 2026
markcoletti
left a comment
markcoletti
left a comment
There was a problem hiding this comment.
These look reasonable to me. (And, yes, I see this includes changes I made that were merged into you branch.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do not write prte's stdout to a pipe, write it to a unique log file instead
strip the newline when reading the DVM URI
WARNING: ensemble summary can hide failures in subcomponents