feat(storage): backup rotation with count/age retention - #55
Merged
Conversation
- Store.RotateBackups(dir, keep, maxAge): keep newest N, prune maxAge-exceeded backups, never delete the newest backup by age alone so an idle store never ends up with zero backups - Sweeps stale *.tmp files from interrupted Backup operations (24h) - Works with timestamped names; ordering is mtime-based - Tests: count/age retention, newest-protection, no-limit pass-through, tmp sweeping, empty/invalid dir handling, and end-to-end Backup+rotate
This was referenced Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 follow-up to #51.
Problem: repeated
Backupcalls accumulate unbounded snapshot files; nothing prunes them.Solution:
Store.RotateBackups(ctx, dir, keep, maxAge)keepbackups (0 = unlimited count), deletes the restmaxAge(0 = unlimited age).tmpfiles left by interruptedBackupwrites (older than 24h)No interface changes, additive only. 7 unit tests + end-to-end Backup+rotate cycle; full suite green.