Repository navigation
Fix no shx negative record size mem leak - #455
Merged
JamesParrott merged 4 commits intoNov 6, 2026
Merged
JamesParrott merged 4 commits into
JamesParrott merged 4 commits into
Conversation
Reproduces issue 453 Overwrite record length with -4 (16bw) to make header+len == 0 seek(0) before corrupting shape record length Switch LE to BE (correct the type of corruption we want!) Co-Authored-By: lunuyennhi-dev <325280363+lunuyennhi-dev@users.noreply.github.com>
Renamed the exception as the shape type is technically in the record Don't raise CorruptShpShapeRecord on a Null Shape body, not the header.reproduces issue 453 Co-authored-by: lunuyennhi-dev <325280363+lunuyennhi-dev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #453
I also added end-of-file-checker to pre-commit, so this PR hits a lot of other files with trivial changes