Skip to content

fix: prevent null dereference in adjustTransformMtx when getContain() is null - #578

Open
seer-by-sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/client-54p-null-getcontain
Open

fix: prevent null dereference in adjustTransformMtx when getContain() is null#578
seer-by-sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/client-54p-null-getcontain

Conversation

@seer-by-sentry

Copy link
Copy Markdown

This PR addresses issue CLIENT-54P by adding a null check in W3DDependencyModelDraw::adjustTransformMtx.

Previously, the code would attempt to dereference the result of me->getContainedBy()->getContain() without verifying if getContain() returned a valid pointer. If the container object lacked a Contain module, getContain() would return null, leading to an EXCEPTION_ACCESS_VIOLATION_READ (0x0) when isEnclosingContainerFor(me) was called on the null pointer.

The fix introduces a null check for getContain() before its dereference, ensuring that isEnclosingContainerFor(me) is only called when a valid Contain module exists.

Fixes CLIENT-54P

This PR was automatically generated by Sentry. You can adjust this setting at any time.

@github-actions

Copy link
Copy Markdown

⚠️ Title/Commit Validation Failed

Invalid PR title:

  • fix: prevent null dereference in adjustTransformMtx when getContain() is null

Invalid commit messages:

  • fix: prevent null dereference in adjustTransformMtx when getContain() is null
    PR titles and commit messages must follow conventional commits format:
type: Description
type(scope): Description

Allowed types: bugfix, build, chore, ci, docs, fix, feat, perf, refactor, revert, style, test, tweak, unify

See CONTRIBUTING.md for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants