fix: prevent null dereference in adjustTransformMtx when getContain() is null - #578
Open
seer-by-sentry[bot] wants to merge 1 commit into
Open
fix: prevent null dereference in adjustTransformMtx when getContain() is null#578seer-by-sentry[bot] wants to merge 1 commit into
seer-by-sentry[bot] wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue CLIENT-54P by adding a null check in
W3DDependencyModelDraw::adjustTransformMtx.Previously, the code would attempt to dereference the result of
me->getContainedBy()->getContain()without verifying ifgetContain()returned a valid pointer. If the container object lacked aContainmodule,getContain()would return null, leading to anEXCEPTION_ACCESS_VIOLATION_READ(0x0) whenisEnclosingContainerFor(me)was called on the null pointer.The fix introduces a null check for
getContain()before its dereference, ensuring thatisEnclosingContainerFor(me)is only called when a validContainmodule exists.Fixes CLIENT-54P
This PR was automatically generated by Sentry. You can adjust this setting at any time.