fix(peer): route Tauri events once - #2364
Merged
Merged
Conversation
The regression was introduced by Bob Lee in commit 14c4b5c, which moved the stateful runtime-session cursor routing into every logical Tauri listener. The first subscriber advanced SessionStream, causing later subscribers to drop the same terminal event. Share each native Tauri listener across all adapter instances so surface and cursor routing runs once before logical subscriber fan-out. Keep subscription ownership isolated per adapter and preserve held-event delivery semantics. Add regressions for cross-adapter fan-out, adapter-specific disconnect, and attachment-held events. Refs: 14c4b5c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regression was introduced by Bob Lee in commit
14c4b5c, which moved the stateful
runtime-session cursor routing into every logical Tauri listener. The first
subscriber advanced SessionStream, causing later subscribers to drop the same
terminal event.
Share each native Tauri listener across all adapter instances so surface and
cursor routing runs once before logical subscriber fan-out. Keep subscription
ownership isolated per adapter and preserve held-event delivery semantics.
Add regressions for cross-adapter fan-out, adapter-specific disconnect, and
attachment-held events.
Refs: 14c4b5c