Repository navigation
[RFC] fwk: lotus: debounce input deck power-off - #97
Open
arthurvanh wants to merge 1 commit into
Open
arthurvanh wants to merge 1 commit into
arthurvanh wants to merge 1 commit into
Conversation
A single full scan in which any hub board ID channel misreads cuts input deck power immediately, while power-on is already debounced by INPUT_MODULE_POWER_ON_DELAY. On affected units this power-cycles the keyboard and touchpad every few seconds in Auto mode. Require the deck to read as not fully populated for more than INPUT_MODULE_DISCON_DEBOUNCE before powering it off. BRANCH=fwk-tulip-29169 BUG=input deck power-cycles every few seconds in Auto mode TEST=none; not built or flashed (work machine). Needs verification on hardware: Auto mode should show no keyboard USB disconnects, and removing a module should still power the deck off. Signed-off-by: Arthur <avanhoorebeke@gmail.com>
arthurvanh
marked this pull request as ready for review
October 30, 2026 07:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Untested – not built or flashed; I didn't want to flash the EC on my work laptop.
A single full scan in which any hub board ID channel misreads cuts input deck power immediately, while power-on is already debounced by
INPUT_MODULE_POWER_ON_DELAY. On affected units this power-cycles the keyboard and touchpad every few seconds in Auto mode.Require the deck to read as not fully populated for more than
INPUT_MODULE_DISCON_DEBOUNCEbefore powering it off.Evidence (Laptop 16, Ryzen AI 7 350, BIOS 04.01, EC
tulip-4.0.1-9b2a0b1)framework_tool --inputdeck-mode auto→ drops within seconds;--inputdeck-mode on→ stable immediately.framework_tool --inputdeckreports the same modules (Pos 1 FullWidth, touchpad present) even in snapshots taken while the deck state isDisconnected/TurningOn.--inputdeck-mode on) works around it.Possibly related: https://community.frame.work/t/framework-16-keyboard-numpad-and-touchpad-disconnect-stop-working/67132/18
Note: I used AI to help write the commit message and analysis.
BRANCH=fwk-tulip-29169
BUG=input deck power-cycles every few seconds in Auto mode
TEST=none; not built or flashed (work machine). Needs verification on hardware: Auto mode should show no keyboard USB disconnects, and removing a module should still power the deck off.