Repository navigation
Recognize davinci - #869
Draft
eugeniobet-ping wants to merge 4 commits into
Draft
eugeniobet-ping wants to merge 4 commits into
eugeniobet-ping wants to merge 4 commits into
Conversation
Add a PingOne server config entry used to exercise the Recognize connector in the davinci-app e2e app.
Add @forgerock/recognize to the davinci-app e2e dependencies, with the matching tsconfig project reference and pnpm-lock entry.
Map the PingOne Recognize connector's RECOGNIZE field to a new
RecognizeCollector (ObjectValueAutoCollector) that exposes the web SDK
configuration (action, serviceURL, customerName, username,
transactionData, webSDKOptions) in its output. The application sets
either { transactionJWT } or { error } on the collector via update(),
which is validated in resolveCollectorUpdateValue.
Add a recognize component that initializes the Recognize web SDK from the collector output config and updates the collector with the resulting transactionJWT or error, and wire it into main.ts.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
View your CI Pipeline Execution ↗ for commit e6ea8fc
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
@forgerock/davinci-client
@forgerock/device-client
@forgerock/journey-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/recognize
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #869 +/- ##
===========================================
+ Coverage 18.07% 96.29% +78.22%
===========================================
Files 155 1 -154
Lines 24398 81 -24317
Branches 1203 17 -1186
===========================================
- Hits 4410 78 -4332
+ Misses 19988 3 -19985 🚀 New features to boost your workflow:
|
Contributor
|
Deployed 04cfe94 to https://ForgeRock.github.io/ping-javascript-sdk/pr-869/04cfe944e8844af65f15f711fe6f82821f6e5187 branch gh-pages in ForgeRock/ping-javascript-sdk |
Contributor
Interface Mapping Out of DateThe Drift reportTo fix, run: pnpm mapping:generateThen commit the updated |
Contributor
📦 Bundle Size Analysis📦 Bundle Size Analysis🚨 Significant Changes🔻 @forgerock/journey-client - 0.0 KB (-95.4 KB, -100.0%) 📊 Minor Changes📈 @forgerock/davinci-client - 60.5 KB (+0.7 KB) ➖ No Changes➖ @forgerock/recognize - 5605.5 KB 15 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.