Repository navigation
fix(gstat): Use correct RHD, RHDE and RHDF based on header flags in gstat - #9245
Open
TreeHunter9 wants to merge 2 commits into
Open
TreeHunter9 wants to merge 2 commits into
TreeHunter9 wants to merge 2 commits into
Conversation
…stat - Changes in dpm.epp and sqz.cpp are related to the edge case where record size is big for RHDE (cannot store it with this header), but is enough for RHD, so the whole record will be put in tail, the head will not contain any data;
hvlad
reviewed
Oct 27, 2026
| * | ||
| **************************************/ | ||
| fb_assert(m_length > outLength); | ||
| [[maybe_unused]] const bool truncateAll = m_length <= outLength; |
Member
There was a problem hiding this comment.
May be it is better to fix caller (store_big_record()) and not break compressor assumptions ?
Contributor
Author
There was a problem hiding this comment.
I'm not sure that we are breaking compressor assumption. As I see, it's fine that we can have head with no data, so at least outLength can be equal to m_length. But, anyway, I think it's fine that outLength can also be bigger then m_length because outLength is more like a buffer size, and return value will contain actual length anyway, so I see no restriction why we should limit outLength value to m_length (except branch if (m_runs.isEmpty()) at the beginning will break if outLength is bigger then m_length, but I can fix that).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in dpm.epp and sqz.cpp are related to the edge case where record size is big for RHDE (cannot store it with this header), but is enough for RHD, so the whole record will be put in tail, the head will not contain any data;
This patch affects v5 and v6.
Related to #9244.