Skip to content

fix(dpm): Handle case where big record cannot be stored on single page with RHDE header, but with RHD it can be stored #9244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TreeHunter9 wants to merge 2 commits into
base: v4.0-release
Choose a base branch
from
Open

fix(dpm): Handle case where big record cannot be stored on single page with RHDE header, but with RHD it can be stored #9244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4274ee4
fix(dpm): Handle case where big record cannot be stored on single pag…
Oct 26, 2026
a16560e
fix(gstat): Use correct record header according to record flags
Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/jrd/dpm.epp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3716,7 +3716,10 @@ static void store_big_record(thread_db* tdbb,
// The last fragment should have rhd header because rhd_incomplete flag won't be set for it.
// It's important for get_header() function which relies on rhd_incomplete flag to determine header size.
FB_SIZE_T header_size = RHD_SIZE;
USHORT max_data = dbb->dbb_page_size - (static_cast<USHORT>(sizeof(data_page)) + header_size);
// We can have a big record that is not fitting into single page with RHDE header, but with RHD header
// it does fit into single page, so to handle such case use `size` as maximum possible data, write whole
// data in tail with RHD, and create head with no data at all.
USHORT max_data = MIN(dbb->dbb_page_size - (static_cast<USHORT>(sizeof(data_page)) + header_size), size);

// Fill up data pages tail first until what's left fits on a single page.

Expand Down
16 changes: 14 additions & 2 deletions src/utilities/gstat/dba.epp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1434,6 +1434,10 @@ static bool analyze_data_page( dba_rel* relation, const data_page* page, bool sw
relation->rel_record_space -= RHDF_SIZE;
relation->rel_record_space += analyze_fragments(relation, header);
}
else if (header->rhdf_flags & rhd_long_tranum)
{
relation->rel_record_space -= RHDE_SIZE;
}
else
{
relation->rel_record_space -= RHD_SIZE;
Expand Down Expand Up @@ -1538,10 +1542,16 @@ static ULONG analyze_fragments(dba_rel* relation, const rhdf* header)
const data_page::dpg_repeat* index = &page->dpg_rpt[f_line];
if (!index->dpg_offset)
break;
space += index->dpg_length;
space -= RHDF_SIZE;
header = (const rhdf*) ((SCHAR *) page + index->dpg_offset);

space += index->dpg_length;
if (header->rhdf_flags & rhd_incomplete)
space -= RHDF_SIZE;
else if (header->rhdf_flags & rhd_long_tranum)
space -= RHDE_SIZE;
else
space -= RHD_SIZE;

fragments++;
}

Expand Down Expand Up @@ -1741,6 +1751,8 @@ static ULONG analyze_versions( dba_rel* relation, const rhdf* header)
space -= RHDF_SIZE;
space += analyze_fragments(relation, header);
}
else if (header->rhdf_flags & rhd_long_tranum)
space -= RHDE_SIZE;
else
space -= RHD_SIZE;
}
Expand Down
Loading