Repository navigation
COR-6538: update marker and record example - #247
Open
tungntEmotiv wants to merge 3 commits into
Open
tungntEmotiv wants to merge 3 commits into
tungntEmotiv wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Failed subscription requests can block data retrieval for existing streams, while session-setup failures can leave callers marked connected with a closed client, preventing retries.
2 open issues
What changed in this PR
This PR separates headset session setup from stream subscription in the MATLAB/Octave SDK, allowing recording and marker operations to reuse the same session without subscribing to data.
Changes:
- Adds reusable session setup and public record/marker functions.
- Tracks recording state in the shared context and exposes internal record/marker helpers.
- Adds a keyboard-controlled recording example and updates the subscription example and documentation.
| File | Description |
|---|---|
octave/README.md |
Documents session setup and record/marker workflows. |
octave/internal/CortexRecord.m |
Implements record creation and stopping. |
octave/internal/CortexMarker.m |
Implements marker injection and interval updates. |
octave/internal/CortexManager.m |
Lazily provides record and marker helpers. |
octave/internal/CortexHeadset.m |
Clears recording state when a session closes; updates comments. |
octave/internal/CortexContext.m |
Stores recording status and record ID. |
octave/functions/cortexSubscribe.m |
Subscribes streams using an existing session. |
octave/functions/cortexSession.m |
Creates or reuses a headset session. |
octave/functions/cortexRecord.m |
Exposes record start/stop operations. |
octave/functions/cortexMarker.m |
Exposes marker operations and options. |
octave/functions/cortexDisconnect.m |
Handles close errors and clears recording fields. |
octave/functions/cortexConnect.m |
Initializes public recording fields. |
octave/examples/subscribeAndPlot.m |
Creates a session before subscribing. |
octave/examples/recordAndMarker.m |
Demonstrates keyboard-controlled recording and markers. |
Review effort: Balanced
tungntEmotiv
force-pushed
the
COR-6538
branch
from
November 4, 2026 10:07
bf6a689 to
74a2006
Compare
tungntEmotiv
requested review from
nhungpham11 and
thamha-emotiv
and
a balanced review from Copilot
November 4, 2026 15:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The PR to update
Now the branch is checked out from COR-6536. after the COR-6536 is merged i will change the destination to COR-1866
Please help to review