Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, it seems the Qt5/Qt6 issue is never resolved...
On Ubuntu 24.04,
navmap_rviz_pluginfails to configure when the Qt6 development files are installed:rviz_common15.2.2 is built against Qt5, but itsrviz_common-extras.cmakelooks for Qt6 first and only falls back to Qt5 if Qt6 is missing. With Qt6 installed, Qt5 is never loaded, and the exported-dependencies step then runs a barefind_package(Qt5), which fails.The existing Qt detection that we have in the CMakeLists.txt for the plugin (
get_target_propertyonrviz_common::rviz_common) runs afterfind_package(rviz_common), so CMake never reaches it. CMake aborts with an error when callingfind_package(rviz_common).Fix
Before
find_package(rviz_common), readrviz_common's exported dependencies to work out whether it uses Qt5 or Qt6:qt_major, which is used forfind_package(Qt${qt_major} ...)and linking, as before;CMAKE_DISABLE_FIND_PACKAGE_Qt6so rviz's extras don't pick up Qt6.