Skip to content

Pin Go, golangci-lint and goreleaser in mise.toml - #64

Merged
DomBlack merged 1 commit into
mainfrom
dom/mise-tools
Oct 30, 2026
Merged

DomBlack merged 1 commit into
mainfrom
dom/mise-tools

Conversation

@DomBlack

@DomBlack DomBlack commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner

The Go version was written out in five places across the two workflows and golangci-lint's in another, and nothing was pinned for working locally, so my machine and CI could quietly drift apart.

So mise.toml is now the one place those versions live, and CI installs them with jdx/mise-action. The lint step runs the golangci-lint mise put on PATH (install-mode none) rather than downloading its own, and the release job just runs goreleaser rather than going through goreleaser-action.

The release workflow only runs on a tag, so this PR doesn't exercise it. It's the same mise setup as the CI jobs though, plus goreleaser 2.x, which is what the action was resolving anyway.

setup-go was also caching Go modules and the build cache, which mise-action doesn't (it only caches the toolchain), so the Go jobs now cache those themselves with actions/cache, keyed on go.sum and mise.toml.

Copilot AI balanced review requested due to automatic review settings October 30, 2026 13:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

The Go version was written out in five places across the two workflows,
golangci-lint's in another, and none of it was pinned for local work, so
my machine and CI could quietly drift apart.

mise.toml is now the one place these versions live. CI installs them
with jdx/mise-action, the lint step runs the golangci-lint mise put on
PATH, and the release job runs goreleaser directly instead of through
its action. setup-go used to cache Go modules and builds as well, which
mise-action doesn't, so the test jobs now cache those themselves.
Copilot AI balanced review requested due to automatic review settings October 30, 2026 13:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@DomBlack
DomBlack merged commit 6ae1ad5 into main Oct 30, 2026
5 of 6 checks passed
@DomBlack
DomBlack deleted the dom/mise-tools branch October 30, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants