Repository navigation
feat(registry): register the two scope-choice refusal codes - #29
Merged
Merged
Conversation
Add requested_option_unavailable and conflicting_requested_options as search refusals on the dataset_resubmit door (problem details, 422), in the registry and its packaged mirror.
Each definition covers every case dfo-apis refuses with it: an axis the part does not offer, an option the axis does not list or an unavailable one, and entries that conflict or rule out every option of an axis. The client contract gives both a fix_request row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers the two refusals Search answers when a
dataset_resubmitposts scope entries it cannot compile:requested_option_unavailable(an entry names an option the part does not offer, or offers unavailable) andconflicting_requested_options(two entries settle one axis differently, or settle conflicting axes). Both are search refusals on thedataset_resubmitdoor, answered as 422 problem details, inregistries/codes.jsonand its mirrorpython/spec-kit/src/dfo_spec_kit/registry/codes.json.dfo-apis pins this commit on its scope-choices branch, so this merges first and the dfo-apis pin moves to the merge commit before that PR merges.
Testing: the registry's own checks and the dfo-apis tests that read these codes through the pin.