Remove OGC retry and deprecate OGC interruptions - #391
Open
thodson-usgs wants to merge 3 commits into
Open
Conversation
Both modules became pure pass-throughs in d7b98eb, when fan-out execution moved to the shared transport layer. Nothing in the package imports either one: transport.fanout takes the classifiers from dataretrieval.interruptions directly, and ogc/__init__ exposes neither module. Remove ogc/retry.py. Its remaining surface was the two private classifiers _classify_chunk_error and _classify_transient; the public RetryPolicy and the _RETRY_* tunables that v1.2.0 published there were already dropped, so the shim protected no import a caller is entitled to make. The single-home guard moves to the classification leaf and now also asserts the module stays gone. Deprecate ogc/interruptions.py rather than deleting it. v1.2.0 defined ChunkInterrupted, QuotaExhausted and ServiceInterrupted in that module, so a pinned caller may still import from the path. It now warns on import, follows the wateruse alias convention, and publishes a horizon in the shared REMOVALS table. Only the path is deprecated -- ChunkInterrupted remains a permanent alias of FanOutInterrupted, and the re-export forwards rather than copies, so identity and except clauses are unaffected. ogc/__init__ imports neither module, so import dataretrieval and import dataretrieval.ogc stay silent. Docstring cross-references in ogc/chunking.py and ogc/errors.py move to the leaf so they do not dangle. ADR 0009's mention of ogc.retry is left alone as a historical record. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ehinman
reviewed
Aug 25, 2026
thodson-usgs
changed the title
thodson-usgs
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to review feedback on #387. This removes the obsolete
dataretrieval.ogc.retrymodule and deprecates the publicdataretrieval.ogc.interruptionsimport path after fan-out execution moved to the shared transport layer.ogc.retryis removed because its remaining exports were private classifiers. Retry policy lives indataretrieval.transport.retry.ogc.interruptionsremains as an identity-preserving compatibility shim because v1.2.0 exposed public exception classes from that path. Direct imports warn and namedataretrieval.interruptionsor the top-level exceptions as replacements.import dataretrievalandimport dataretrieval.ogcremain silent.Validation