Skip to content

Improvement: Mesh handle: repartition element data is now protected, correced bug if one process does not have element data - #2641

Merged
spenke91 merged 2 commits into
mainfrom
mesh_handle_repart_protected
Nov 2, 2026
Merged

spenke91 merged 2 commits into
mainfrom
mesh_handle_repart_protected

Conversation

@lenaploetzke

@lenaploetzke lenaploetzke commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Closes #2643

Describe your changes here:

  1. Fix: Users now cant repartition element data by hand, they should use the commit function for this.
  2. If the variable data_set was not the same on all processes, e.g. because of empty processes, we can run into problems because of collective function calls, e.g. repartition element data.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation. Make sure to add a file documentation for each file!
  • README.md files are updated if necessary.
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the scripts/internal/find_all_source_files.sh to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@codecov

codecov Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.08%. Comparing base (fb60a9b) to head (8797a7c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2641   +/-   ##
=======================================
  Coverage   83.07%   83.08%           
=======================================
  Files         148      148           
  Lines       22274    22276    +2     
=======================================
+ Hits        18505    18507    +2     
  Misses       3769     3769           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spenke91 spenke91 self-assigned this Nov 2, 2026
@spenke91
spenke91 self-requested a review November 2, 2026 14:42

@spenke91 spenke91 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me👍

@spenke91
spenke91 enabled auto-merge November 2, 2026 15:32
@spenke91
spenke91 added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit 38a1bbd Nov 2, 2026
27 checks passed
@spenke91
spenke91 deleted the mesh_handle_repart_protected branch November 2, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvement: Mesh handle: repartition element data is now protected, correced bug if one process does not have element data

2 participants