Repository navigation
Add Pixi package manifests for the CoreSense Pixi channels - #1
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Both manifests contain an unsupported backend field that will cause Pixi to reject them.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Adds Pixi manifests for physics_amm and physics_amm_msgs to enable ROS package builds and publication through CoreSense Pixi channels.
Changes:
- Adds
pixi-build-rosbackend configuration. - Enables Pixi packaging for both packages.
- Retains
package.xmlas the metadata source.
| File | Review |
|---|---|
ros2/physics_amm/pixi.toml |
Critical issue (1 vote): remove unsupported workspace = true from [package.build.backend]. |
ros2/physics_amm_msgs/pixi.toml |
Critical issue (1 vote): remove unsupported workspace = true from [package.build.backend]. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| [package.build.backend] | ||
| name = "pixi-build-ros" | ||
| workspace = true |
|
|
||
| [package.build.backend] | ||
| name = "pixi-build-ros" | ||
| workspace = true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR only adds a
pixi.tomlfile next to thepackage.xmlof these packages, so they can be built with pixi-build-ros and included in the final release of the CoreSense software in the CoreSense Pixi channels (coresense-jazzy, coresense-kilted) on Wednesday 30 September:physics_ammphysics_amm_msgsThe file does not change your code or the build: it only tells Pixi to build the package from its
package.xml, which remains the single source of truth.These packages have been built with Pixi against ROS 2 Jazzy (RoboStack), from the current
mainbranch.More information in the CoreSense guide. Please merge it if you agree, and do not hesitate to ask any question. Thank you!
🤖 Generated with Claude Code