Repository navigation
gnome-shell-extension-appindicator: one icon for an item found twice - #42
Merged
Merged
Conversation
Trayscale, started at login, showed two tray icons: it registers by a standard SNI name, the startup scan finds the same object by its unique name, and the watcher keyed the two differently. The fork now carries upstream PR #679 (#665), which keys every item by its owner's unique name and its path. task test:usb's top bar shows one icon again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trayscale, started at login, showed two tray icons: it registers with a standard SNI name (
org.freedesktop.StatusNotifierItem-PID-N), the extension's startup scan finds the same object by its unique bus name, and the watcher keyed the two differently.RegisteredStatusNotifierItemslisted the same item twice; the extra icon moved the clock and the date menu 56 logical pixels left, failingshell-calendar,shell-calendar-focusandshell-notifications.The fork (Construct-Linux/gnome-shell-extension-appindicator, gnome-51, b32d8c7) now carries upstream PR ubuntu/gnome-shell-extension-appindicator#679 (fixes #665): every item is keyed by its owner's unique name and its object path. Its 15 regression tests pass on the fork (10 fail without the fix, among them the standard SNI name case); the mocks were adapted to the fork's
SignalConnectionPromiseand cancellable.task build -- gnome-shell-extension-appindicator,task lock: the lock moves the extension and its-langfrom 66-r5 to 66-r6, nothing of Wolfi's.task test:usb: one Trayscale icon in the top bar. The three shell views still differ from their needles by that one legitimate icon (~3.5%); their new look is approved in Construct-Linux/needles bytask needles:propose.🤖 Generated with Claude Code