Repository navigation
harness: dbx current fetches LVFS's metadata itself - #38
Merged
Merged
Conversation
Waiting for the metadata failed every run of test:usb on the merged tree: fwupd's own refresh is an hourly timer with an hour's random delay and GNOME Software's comes when it comes, so three minutes after login the file was often not there. A cold fwupdmgr refresh takes seconds, and the check no longer depends on who else got there first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dbx current, added in #37, failed everytask test:usbon the merged tree (enrolled 0). The machine was right and the check was wrong: it waited three minutes for LVFS's metadata, but fwupd's own refresh is an hourly timer with up to an hour's random delay, and GNOME Software's comes when it comes.The check now runs
fwupdmgr refresh --forceitself and still requires the refresh to succeed. A cold refresh took 3 s in a VM just after boot.Checked at this commit
task check: passedtask test:usbthree times: all passed, the last 631/631, withdbx current: enrolled metadata 0in eachThe check now depends on reaching LVFS: without it, it fails instead of passing on stale data.
🤖 Generated with Claude Code