Skip to content

N°9984 - Error while compiling iTop 3.3 with PMP Extended - #1029

Merged
Lenaick merged 2 commits into
developfrom
feature/9984-error-while-comiling-itop-3-3-with-pmp-extended
Aug 28, 2026
Merged

N°9984 - Error while compiling iTop 3.3 with PMP Extended#1029
Lenaick merged 2 commits into
developfrom
feature/9984-error-while-comiling-itop-3-3-with-pmp-extended

Conversation

@Lenaick

@Lenaick Lenaick commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI balanced review requested due to automatic review settings August 26, 2026 14:09
@CombodoApplicationsAccount CombodoApplicationsAccount added the internal Work made by Combodo label Aug 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Recomputes selected modules when resuming the upgrade wizard to prevent compilation errors.

Changes:

  • Rebuilds wizard steps and component selections.
  • Persists the derived module list.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread setup/wizardsteps/WizStepLandingBeforeAudit.php Outdated
@greptile-apps

greptile-apps Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR corrects module selection before the compatibility audit for installation definitions containing multiple wizard steps.

  • Recomputes selected components when the fallback path is used.
  • Advances the component-selection index for each wizard step.
  • Stores the resulting module identifiers in the wizard state for compilation.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the per-step selection index now advances as each installation step is processed.

Important Files Changed

Filename Overview
setup/wizardsteps/WizStepLandingBeforeAudit.php The fallback now maps each wizard step to its corresponding selected components while rebuilding the module list.

Reviews (2): Last reviewed commit: "N°9984 - Error while compiling iTop 3.3 ..." | Re-trigger Greptile

Comment thread setup/wizardsteps/WizStepLandingBeforeAudit.php Outdated
@Lenaick
Lenaick force-pushed the feature/9984-error-while-comiling-itop-3-3-with-pmp-extended branch from 4814a9d to aa9af8f Compare August 26, 2026 14:28
@Molkobain Molkobain added this to the 3.3.0 milestone Aug 26, 2026
@Lenaick
Lenaick merged commit e769e53 into develop Aug 28, 2026
@Lenaick
Lenaick deleted the feature/9984-error-while-comiling-itop-3-3-with-pmp-extended branch August 28, 2026 08:01
@Lenaick
Lenaick restored the feature/9984-error-while-comiling-itop-3-3-with-pmp-extended branch August 28, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Work made by Combodo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants