Make problem creation registry-driven and model-owned - #1132
Merged
Conversation
This was referenced Aug 11, 2026
* refactor: declare model categories explicitly * refactor: preserve typed categories in graph export
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreateArgswith a deferred, registry-driven Clap parserCreateSpec+TryFromimplementationsResulting extension contract
An ordinary new model registers its schema and variants in the model module; CLI and MCP discover it without frontend changes. A model whose public construction input differs from its persisted representation defines a local typed
CreateSpecand fallible conversion. Random generation is registered only for variants with a meaningful generator. Each schema explicitly selects one of the five established structural categories.Unknown inputs, missing required inputs, invalid values, unsupported random generation, and missing registry metadata fail explicitly. There are no model-name fallbacks in CLI or MCP.
Stack
1075-growth-domain)mainafter Exact symbolic growth, unified reduction size contracts, and deterministic solver backends #1083 merges.Known trade-offs
pred createbuilds lightweight subcommand shells for registered variants, but expands dynamic flags only for the selected variant. Startup work therefore remains linear in the number of registered variants.Verification
cargo test --workspace --all-targets --features mcpcargo test -p problemreductions-cli --all-targets --features mcpcargo test -p problemreductions --doccargo clippy --workspace --all-targets --features mcp -- -D warningspred list, unknown-category, SCS derived-field, and composite graph construction checksCloses #1133
Closes #1135