Repository navigation
London | 26-ITP-Sep| Abdennour Hachemi | Sprint 2 | Implement-and-rewrite-tests - #1761
AbdennourHachemi wants to merge 10 commits into
Conversation
This reverts commit 7c634be. print-3-implement-and-rewrite
This comment has been minimized.
This comment has been minimized.
iscmiguelsamaniego
left a comment
There was a problem hiding this comment.
Great work overall! Your implementations and test suites show a solid understanding of logic and edge cases.
Before final approval, please clean up any duplicated test blocks, ensure proper closing brackets, and verify function scopes. Excellent progress!
There was a problem hiding this comment.
Thanks for sharing your tests! You’ve set up a solid foundation covering the main angle categories.
Are there any boundary values or edge cases (such as 0°, 360°, or negative numbers) that might be worth including to ensure the function handles all possible inputs precisely?
There was a problem hiding this comment.
Solid tests! Have you noticed a couple of minor typos in the descriptions, and might negative numbers be worth covering?
There was a problem hiding this comment.
Great test coverage for valid cards and invalid formats! How might the function handle lowercase inputs or missing values?
There was a problem hiding this comment.
Solid implementation! What happens if a negative number is passed into the function?
There was a problem hiding this comment.
Solid implementation! How does the function handle negative numbers, and should they be considered proper fractions in this context?
There was a problem hiding this comment.
Clean regex logic! Notice where the function's closing brace is placed—is all of that implementation code currently inside the function body?
There was a problem hiding this comment.
Great coverage of the angle types! Have you checked the syntax of the first test block—is anything missing at the end before the next test starts?
There was a problem hiding this comment.
Nice test coverage! Have you noticed the duplicated test blocks throughout the file
There was a problem hiding this comment.
Comprehensive and thorough test suite covering numbers, face cards, and multiple error formats! Have you considered whether testing the Ace card is also needed in this block?
Self checklist
CYF-1059