Skip to content

London | 26-ITP-Sept | Hugh Mills | Sprint 3 | Coursework Dead Code - #1742

Open
HM-127BTY wants to merge 6 commits into
CodeYourFuture:mainfrom
HM-127BTY:coursework/sprint-3-dead-code
Open

HM-127BTY wants to merge 6 commits into
CodeYourFuture:mainfrom
HM-127BTY:coursework/sprint-3-dead-code

Conversation

@HM-127BTY

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1066

Changelist

Removed and edited code to remove dead code found in the tasks.

…is code.

removed console.log(greetingStr) as the return stops the function and never reaches that consol.log.
Cleaned up the code as it doing the same request twice in it.
Removed function logPets for same reason
@HM-127BTY HM-127BTY added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 21, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Comment thread dead-code/exercise-1.js Outdated
Comment on lines +7 to +8
// 'hello, Aman!'
console.log(sayHello("hello", "Aman"));

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: In this exercise, you were supposed to only delete dead code, not refactor the code.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bugger... Ok I recovered the code from main and did the fix. I need to practice recovering from past saves on vscode as in this moment I ended up doing a copy/paste from the main branch of the code to mine so I can redo it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tool you need to recover from past commits is Git, not VS Code.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 24, 2026
removed lines 8 and 10 as they are not needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants