London | 26-ITP-Sep | Maharit Belai | Sprint 2| Practice TDD by MaharitB · Pull Request #1729 · CodeYourFuture/Module-Structuring-and-Testing-Data

MaharitB · 2026-10-17T21:21:13Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1060

Changelist

I practiced writing a code based on Test driven development.

Questions

…ent exit in the string,test failed

…passed

…st failed

…o,test passed.

…given more than one character

…acter

… and added a test for empty string

…ers. Both passed

…h a decimal input

mayowaolokun

Thank you for the updates, this is great progress. The main issues from the first review have been addressed: the 111, 112 and 113 cases now work, the zero case in repeatStr returns an empty string, and the test names are much clearer.

I’ve left a few smaller comments.
You’re very close, so keep up the good work!

mayowaolokun · 2026-10-25T22:31:21Z

-// When the function is called with these inputs,
-// Then it should return 0, indicating that no occurrences of `char` were found.
+
+test(" Should count 0", () => {


“Should count 0” is clearer than before. It might help to describe the scenario, for example, that the character doesn’t appear in the string. There’s also still a space at the start of the name.

mayowaolokun · 2026-10-25T22:32:34Z

+  const count = countChar(str, char);
+  expect(count).toEqual(1);
+});
+test("should count multiple occurences of character empty space", () => {


“Empty space” could be confused with an empty string. Would “space character” describe this test more clearly?

mayowaolokun · 2026-10-25T22:32:59Z

+  const count = countChar(str, char);
+  expect(count).toEqual(2);
+});
+test("should count multiple occurences of character in an empty string", () => {


Nice addition. Since this test expects 0, it might be worth removing “multiple occurrences” from the name.

mayowaolokun · 2026-10-25T22:35:15Z

+  const count = countChar(str, char);
+  expect(count).toEqual(0);
+});
+test("should count multiple occurences of character in a sentence", () => {


This test seems to share its name with the one on line 52, so it might be worth giving it a unique name that describes its scenario.

mayowaolokun · 2026-10-25T22:43:56Z

+    throw new Error("Invalid Input");
+  }
+
+  if (numStr.slice(-1) == "1" && numStr.slice(-2) != 11) {


numStr.slice(-2) gives you a string, but it’s compared with the number 11. This currently works because != converts types before comparing. What would happen if you switched to !==, as suggested earlier? It might be worth comparing like with like so the code doesn’t depend on type conversion. Applicable to lines 11 and 14.

mayowaolokun · 2026-10-25T22:55:47Z

+  count = Math.floor(count);
+
+  if (str === " ") {
+    throw new Error("String shoild not be empty");


Small typo: “shoild” should be “should”.

mayowaolokun · 2026-10-25T22:58:54Z

+
+test("should repeat the string count times", () => {
+  expect(() => repeatStr("hello", -1)).toThrow("Negative counts are not valid");
+});


Thank you for adding this test. One thing to check: the input here is a single space " " rather than an empty string "". Please see my comment on line 9 of repeat-str.js, as the two are linked.

mayowaolokun · 2026-10-25T23:01:42Z

+  expect(() => repeatStr("hello", -1)).toThrow("Negative counts are not valid");
+});
+test(`should throw an error when string is empty`, () => {
+  expect(() => repeatStr(" ", 1)).toThrow("String shoild not be empty");


The test name says “empty string”, but the input is a space. Once you’ve decided whether an empty string or a space should be an error, it might be worth updating this test to match. Also, if you fix the “shoild” typo in the error message, remember to update it here too.

mayowaolokun · 2026-10-25T23:02:27Z

-
-// Case: handle count of 1:
-// Given a target string `str` and a `count` equal to 1,
-// When the repeatStr function is called with these inputs,
-// Then it should return the original `str` without repetition.
-


The Given/When/Then comments for the count of 1 and count of 0 cases are still removed. It might be worth restoring them, as you’ve done for the other cases.

mayowaolokun · 2026-10-25T23:03:16Z

+  expect(repeatedStr).toEqual("");
+});
+//case: Handle decimal count:
+test("should repeat the stringthe whole number in the count times", () => {


There’s a missing space in “stringthe”. It might also help to make the name clearer, for example, by saying that a decimal count is rounded down.

…ount

MaharitB added 30 commits October 16, 2026 23:56

wrote a test to count a character in a string where that character do…

cff3419

…ent exit in the string,test failed

edited the test

e3a0787

made a change to the code, test passed

6cd3097

wrote a test , test failed.

5418d11

added some line in the code to make the test pass, two more test failed

86ffa32

added some code to make the test pass,test passed

a23a6a5

wrote a test and it passed

4fffb00

added a test which includes number in the string,test passed

0b8b953

added a test for a £ character,test passed

623a0a6

added a test that would count space between words in a string

cbd3ff3

added a test to count characters in group of words in a string, test …

e0136e6

…passed

test case 1 failed, fixed the code, test passed.

4a71d58

wrote a test for case 2. Test failed

68e09e3

wrote a code to pass the test.test passed

9b5152e

wrote a test for case 3, test failed.

dd1a452

two tests failed so made amend on the code and one test passed,one te…

650bd92

…st failed

make changes to the test code and test passed

a7c42ab

add atest to the testing file and test failed

7f7deb4

added and amended in the code and the test passed

5b59e17

added a test for case 5, exception numbers, test failed.

494887f

made changes to the code and test passed on case 5.

4453a23

added a test to throw an error when the argument is 0. Test failed

91c2378

added a code that throws an error when num is passed with a value zer…

87eb71e

…o,test passed.

wrote a test with count =2, test failed

55e6ea0

added a code to make the test failed pass. Success.

2a2811a

added a test for the case count=1, test failed

119aabb

added a code to make the test pass four count =1, test passed

e8ae9bb

added a test for case where count=0, test failed

c89337c

made a small change to the test file on the expected string

a87428c

wrote a code for case count=0, and test passed

ad818d2

mayowaolokun added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 19, 2026

MaharitB added 13 commits October 19, 2026 21:06

changed all the test names,and added a test for throwing an Error if …

9551f77

…given more than one character

added a code to throw an error if findCharacter is more than one char…

b1e9a88

…acter

added two tests for an empty string and a space

63986b5

added code to make the test past for big numbers ending with 11,like111

cd87177

updated the case name added some more test for numbers ending with 11…

19060bc

… and added a test for empty string

edited a code to include error to throw for empty String

5fab553

wrote back the comment as aadvised and added two more tested

b87e5f4

Edited some cods to make the two tests added for -ve and decimal numb…

2aed003

…ers. Both passed

added back the comment as advised and added a Math method to help wit…

942dc2b

…h a decimal input

added test cases for decimal fixed the name given to the test

52a1d81

added a test for empty string.Test failed

3463aee

wrote a test that throws error when string is empty

08dccc1

restored all coments as advised

9f7796a

MaharitB added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 20, 2026

mayowaolokun added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 25, 2026

mayowaolokun reviewed Oct 25, 2026

View reviewed changes

mayowaolokun added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 25, 2026

MaharitB added 6 commits October 27, 2026 22:40

made some amendments in the test naming.

b8b9b78

edited a code

18c3849

changed the inequality sign and made the value a string as it should be.

ff38621

changed case 6 name and amended case 7 code as advised

963c4a6

edited a code and amende the error name that is thrown

4974e45

added case handle of zero and one , edited the test name of decimal c…

6d1091b

…ount

MaharitB added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 28, 2026

Navigation Menu

Repository navigation

London | 26-ITP-Sep | Maharit Belai | Sprint 2| Practice TDD - #1729

London | 26-ITP-Sep | Maharit Belai | Sprint 2| Practice TDD#1729
MaharitB wants to merge 57 commits into
CodeYourFuture:mainfrom
MaharitB:coursework/sprint-3-practice-tdd

MaharitB commented Oct 17, 2026

Uh oh!

mayowaolokun left a comment

Uh oh!

mayowaolokun Oct 25, 2026

Uh oh!

mayowaolokun Oct 25, 2026

Uh oh!

mayowaolokun Oct 25, 2026

Uh oh!

mayowaolokun Oct 25, 2026

Uh oh!

mayowaolokun Oct 25, 2026

Uh oh!

mayowaolokun Oct 25, 2026

Uh oh!

mayowaolokun Oct 25, 2026

Uh oh!

mayowaolokun Oct 25, 2026

Uh oh!

mayowaolokun Oct 25, 2026

Uh oh!

mayowaolokun Oct 25, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

MaharitB commented Oct 17, 2026

Learners, PR Template

Task code

Changelist

Questions

Uh oh!

mayowaolokun left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants