Repository navigation
Manchester | 26-ITP-Sept | Fatima Rouchi | Sprint 2 | Implement and rewrite tests - #1728
Open
fatimarouchi wants to merge 20 commits into
Open
fatimarouchi wants to merge 20 commits into
fatimarouchi wants to merge 20 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fatimarouchi
changed the title
fatimarouchi
added
the
Needs Review
cjyuan
added
Review in progress
cjyuan
reviewed
Oct 23, 2026
| }); | ||
| // Case 6: Invalid angles | ||
|
|
||
| test('should return "Invalid angle" for invalid angles', () => { |
Contributor
There was a problem hiding this comment.
An exact range of invalid angles could probably make the test description more informative.
cjyuan
added
Reviewed
fatimarouchi
added
Needs Review
Contributor
|
It seems some of the inline comments were not yet addressed. Could you address all the inline comments in addition to making changes? Suggestion: Use AI to explore "How to respond to inline comments in a PR" |
cjyuan
added
Reviewed
Contributor
|
Also, the PR description is missing a Changelist section. Could you also use AI to explore "what to write in the Changelist section of a PR?" |
fatimarouchi
added
Needs Review
cjyuan
reviewed
Oct 27, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
-
The implementation of
isProperFraction()and its Jest tests are not fully compatible. -
Your PR description is missing a "Changelist" section.
Contributor
There was a problem hiding this comment.
-
Could your implementation passes all the tests in this file?
-
Could you look up the definition of proper fraction from an authoritative source (or ask AI)?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
CYF-1059