Skip to content

Manchester | 26-ITP-Sept | Aklilu Tsehaye | Sprint 2 | Practice TDD - #1703

Open
AkliluMihtsun wants to merge 18 commits into
CodeYourFuture:mainfrom
AkliluMihtsun:coursework/sprint-3-practice-tdd
Open

Manchester | 26-ITP-Sept | Aklilu Tsehaye | Sprint 2 | Practice TDD#1703
AkliluMihtsun wants to merge 18 commits into
CodeYourFuture:mainfrom
AkliluMihtsun:coursework/sprint-3-practice-tdd

Conversation

@AkliluMihtsun

@AkliluMihtsun AkliluMihtsun commented Oct 14, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1060

Changelist

I have completed the Practice TDD coursework

@AkliluMihtsun AkliluMihtsun added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 14, 2026
@valentina-starr1

valentina-starr1 commented Oct 14, 2026

Copy link
Copy Markdown

Clean and straightforward implementation. Requirements are met and test coverage looks solid across standard cases and edge conditions (including negative repeats and ordinal teen exceptions. Ready to merge.

@AkliluMihtsun

AkliluMihtsun commented Oct 14, 2026

Copy link
Copy Markdown
Author

Clean and straightforward implementation. Requirements are met and test coverage looks solid across standard cases and edge conditions (including negative repeats and ordinal teen exceptions. Ready to merge.

thank you for reviewing my work and I appreciate your comments

@AkliluMihtsun

AkliluMihtsun commented Oct 17, 2026

Copy link
Copy Markdown
Author

@valentina-starr1 could you please change the label for me if I have met all the requirements

@AkliluMihtsun AkliluMihtsun added the 📅 Sprint 2 Assigned during Sprint 2 of this module label Oct 20, 2026
cjyuan
cjyuan reviewed Oct 23, 2026
View reviewed changes
Comment thread practice-tdd/repeat-str.js Outdated
Comment thread practice-tdd/get-ordinal-number.test.js Outdated
Comment thread practice-tdd/get-ordinal-number.js Outdated
Comment thread practice-tdd/get-ordinal-number.js Outdated
Comment thread practice-tdd/count.test.js
Comment thread practice-tdd/count.test.js Outdated
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 23, 2026
@AkliluMihtsun AkliluMihtsun added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 26, 2026
cjyuan
cjyuan reviewed Oct 26, 2026
View reviewed changes

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Comment thread practice-tdd/get-ordinal-number.js Outdated
Comment thread practice-tdd/count.test.js
@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AkliluMihtsun @valentina-starr1 @cjyuan