Repository navigation
London|26-ITP-Sep|Abdennour Hachemi|Sprint 2 |Practice TDD #1701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AbdennourHachemi
wants to merge
19
commits into
CodeYourFuture:main
Choose a base branch
from
AbdennourHachemi:new/coursework/sprint-3-practice-tdd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
038bb6a
updating count.js file
AbdennourHachemi 7f77ed1
solve excersise count.test.js
AbdennourHachemi eafa02b
solve excersise get-ordinal-number.js
AbdennourHachemi d48367c
solve excersise get-ordinal-number.test.js
AbdennourHachemi 81f14c5
solve excersise repeat-str.js
AbdennourHachemi e69b86d
solve excersise repeat-str.test.js
AbdennourHachemi fa692ca
addinkg .gitignore
AbdennourHachemi 119d10a
remove pakage.json and lock files from gitignore
AbdennourHachemi c6ff944
adding toThrow method
AbdennourHachemi d5f0650
update get-ordinal exercise
AbdennourHachemi fec0df1
remove unnessarry import from count.test.js
AbdennourHachemi cfd965b
correcting spelling typo
AbdennourHachemi c5e9432
adding test case handling the special cases like 11,12,13,101 & 103
AbdennourHachemi 9221e65
delete gitignore file
AbdennourHachemi 37f772e
adding multiple sample test in each category
AbdennourHachemi a450f92
adding an empty string test case
AbdennourHachemi 64feba5
remove repeated comments to avoid redendancy
AbdennourHachemi d31066a
give a better description to test cases
AbdennourHachemi 5081760
running prettier to fromat the code
AbdennourHachemi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,9 @@ | ||
| export function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| let count = 0; | ||
| for (const character of stringOfCharacters) { | ||
| if (character === findCharacter) { | ||
| count++; | ||
| } | ||
| } | ||
| return count; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,21 @@ | ||
| export function getOrdinalNumber(num) { | ||
| return "1st"; | ||
| //handle a non number inputs | ||
| if (!num) { | ||
| return ""; | ||
| } | ||
| const lastTwoDigits = num % 100; | ||
| // Handle exceptions: 11th, 12th, 13th, 111th, etc. | ||
| if (lastTwoDigits >= 11 && lastTwoDigits <= 13) { | ||
| return `${num}th`; | ||
| } | ||
| switch (num % 10) { | ||
| case 1: | ||
| return `${num}st`; | ||
| case 2: | ||
| return `${num}nd`; | ||
| case 3: | ||
| return `${num}rd`; | ||
| default: | ||
| return `${num}th`; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,66 @@ | ||
| import { getOrdinalNumber } from "./get-ordinal-number.js"; | ||
| // In this week's prep, we started implementing getOrdinalNumber. | ||
|
|
||
| // In this week's prep, we started implementing getOrdinalNumber. | ||
| // Continue testing and implementing getOrdinalNumber for additional cases. | ||
| // Write your tests using Jest — remember to run your tests often for continual feedback. | ||
|
|
||
| // To ensure thorough testing, we need broad scenarios that cover all possible cases. | ||
| // Listing individual values, however, can quickly lead to an unmanageable number of test cases. | ||
| // Instead of writing tests for individual numbers, consider grouping all possible input values | ||
| // into meaningful categories. Then, select representative samples from each category to test. | ||
| // This approach improves coverage and makes our tests easier to maintain. | ||
|
|
||
| // Case 1: Numbers ending with 1 (but not 11) | ||
| // When the number ends with 1, except those ending with 11, | ||
| // Then the function should return a string by appending "st" to the number. | ||
| // Case 1: | ||
| test("should append 'st' for numbers ending with 1, except those ending with 11", () => { | ||
| expect(getOrdinalNumber(1)).toEqual("1st"); | ||
| expect(getOrdinalNumber(21)).toEqual("21st"); | ||
| expect(getOrdinalNumber(131)).toEqual("131st"); | ||
| }); | ||
|
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. a test case handling the special cases like 11,12,13,101 & 103 will make this suit more robust. |
||
| // Case 2: | ||
| test("should append 'nd' for numbers ending with 2, except those ending with 12", () => { | ||
| expect(getOrdinalNumber(2)).toEqual("2nd"); | ||
| expect(getOrdinalNumber(32)).toEqual("32nd"); | ||
| expect(getOrdinalNumber(72)).toEqual("72nd"); | ||
| expect(getOrdinalNumber(452)).toEqual("452nd"); | ||
| expect(getOrdinalNumber(862)).toEqual("862nd"); | ||
| }); | ||
|
|
||
| // Case 3: N | ||
| test("should append 'rd' for numbers ending with 3, except those ending with 13", () => { | ||
| expect(getOrdinalNumber(3)).toEqual("3rd"); | ||
| expect(getOrdinalNumber(43)).toEqual("43rd"); | ||
| expect(getOrdinalNumber(93)).toEqual("93rd"); | ||
| expect(getOrdinalNumber(823)).toEqual("823rd"); | ||
| expect(getOrdinalNumber(183)).toEqual("183rd"); | ||
| }); | ||
|
|
||
| // Case 4: | ||
| test("should append 'th' for numbers ending with 4,5,6 ,7 ,8 or 9 ", () => { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are all "other digits" covered in this category? |
||
| expect(getOrdinalNumber(4)).toEqual("4th"); | ||
| expect(getOrdinalNumber(25)).toEqual("25th"); | ||
| expect(getOrdinalNumber(656)).toEqual("656th"); | ||
| expect(getOrdinalNumber(1007)).toEqual("1007th"); | ||
| expect(getOrdinalNumber(638398)).toEqual("638398th"); | ||
| expect(getOrdinalNumber(34454559)).toEqual("34454559th"); | ||
| }); | ||
|
|
||
| // Case 5: | ||
| test("should append 'th' for numbers in 100's ending with 11, 12 , 13", () => { | ||
| expect(getOrdinalNumber(111)).toEqual("111th"); | ||
| expect(getOrdinalNumber(112)).toEqual("112th"); | ||
| expect(getOrdinalNumber(113)).toEqual("113th"); | ||
| }); | ||
|
|
||
| // Case 6:A test case handling the special cases like 11,12,13,101 & 103 | ||
|
|
||
| test("should append 'th' for numbers for 11,12,13 and 'st' for 101 and 'rd' for 103", () => { | ||
| expect(getOrdinalNumber(11)).toEqual("11th"); | ||
| expect(getOrdinalNumber(12)).toEqual("12th"); | ||
| expect(getOrdinalNumber(13)).toEqual("13th"); | ||
| expect(getOrdinalNumber(101)).toEqual("101st"); | ||
| expect(getOrdinalNumber(103)).toEqual("103rd"); | ||
| }); | ||
|
|
||
| test("should return empty string if empty string is passed", () => { | ||
| expect(getOrdinalNumber("")).toEqual(""); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,14 @@ | ||
| export function repeatStr() { | ||
| export function repeatStr(str, count) { | ||
| // Your implementation of this function must *not* call String.prototype.repeat (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat). | ||
| // The goal is to re-implement that function, not to use it. | ||
| return "hellohellohello"; | ||
| if (count < 0) { | ||
| throw new Error("Error! negative counts are not valid"); | ||
| } | ||
| let result = ""; | ||
| let counter = count; | ||
| while (counter > 0) { | ||
| result += str; | ||
| counter--; | ||
| } | ||
| return result; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could consider testing multiple samples in each test category - higher chance to detect bugs in code.
Empty string is often a good edge case to test.
When a specification is ambiguous, programmers may need to make reasonable assumptions based on their understanding of the requirements. In this case, the original specification did not explicitly state whether character matching should be case-sensitive. Although most people would likely assume that it is, adding test cases can help document this assumption and make our interpretation of the specification explicit.
Similarly, we should consider adding tests for any other assumptions made during implementation to clarify the intended behavior and ensure these assumptions are consistently understood and validated.