Repository navigation
Revert "feat(vex): hide RDRAND and RDSEED from CPUID with --deterministic-rng" - #55
not-matthias wants to merge 1 commit into
Conversation
…stic-rng" This reverts commit 81d7365.
[Medium impact] The change affects amd64 feature reporting for guests using deterministic RNG. The PR appears safe to merge, with a non-blocking request to retain the CPUID test checks.
|
| __cpuid_count(7, 0, eax, ebx, ecx, edx); | ||
| printf("cpuid rdseed: %u\n", (ebx >> 18) & 1); | ||
|
|
||
| void* (*draws[])(void*) = { |
There was a problem hiding this comment.
The test no longer checks the behavior this revert restores. Keep the CPUID queries and change the expected bits to 1: deterministic_rng.vgtest already requires both features before running. Without those checks, hiding either feature again would leave this test passing.
Prompt To Fix With AI
This is a comment left during a code review.
Path: none/tests/amd64/deterministic_rng.c
Line: 38
Comment:
**CPUID checks are gone**
The test no longer checks the behavior this revert restores. Keep the CPUID queries and change the expected bits to `1`: `deterministic_rng.vgtest` already requires both features before running. Without those checks, hiding either feature again would leave this test passing.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Merging this PR will not alter performance
Comparing Footnotes
|
As discussed, to avoid timing differences keep the instruction feature flag enabled.