[not-matthias]

Summary

• Add --walltime-unwinding-mode / CODSPEED_WALLTIME_UNWINDING_MODE and --walltime-stack-sample-size / CODSPEED_WALLTIME_STACK_SAMPLE_SIZE.
• Keep --perf-unwinding-mode / CODSPEED_PERF_UNWINDING_MODE as a hidden, deprecated alias. The new option wins when both are set.
• perf: use the explicit stack size instead of the inferred one (default stays 8192 bytes).
• samply (Linux): forward --unwinding-mode and --unwinding-stack-size.

Notes

• Depends on feat(linux): support frame-pointer-only recording samply-codspeed#12. The samply submodule must be bumped to include it; until then samply rejects these flags when the options are set.

[codspeed]

Merging this PR will not alter performance

2 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 8 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 41 untouched benchmarks
⏩ 6 skipped benchmarks¹

---

_{Comparing cod-3877-expose-stack-sampling-size-in-cli (f77fdc8) with main (d14d95d)}

Footnotes

1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[greptile-apps]

Confidence Score: 4/5

[Medium impact] Renames profiler configuration options and adds stack sample size tuning.

The reviewed changes appear safe to merge once the author’s stated samply prerequisite is met; the warning and test feedback are non-blocking.

Findings

1.  Deprecation warning never appears ▶
2.  Option rules lack tests ▶

Fix with agent prompt

### Issue 1
src/cli/shared.rs:258-260
Both `codspeed run` and `codspeed exec` call `resolve_unwinding_mode()` while building the config, before `Orchestrator::new()` installs the logger. This drops the warning, so users of `--perf-unwinding-mode` or `CODSPEED_PERF_UNWINDING_MODE` never learn about the replacement. Emit it after logger setup or use the existing startup-warning approach.

### Issue 2
src/cli/shared.rs:254-261
The new precedence and stack-size overrides have no tests. Add focused cases for the old option alone, both options together, flag/environment combinations, and an explicit size overriding both the default and Python's inferred size. These are the main promises of this change; tests would catch later edits that silently send the wrong value to the profiler.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Adds walltime unwinding and stack-size options to run and exec.

• Walltime profiler settings now choose unwinding mode and stack size.
• The perf profiler now uses the requested DWARF stack size.
• Linux samply runs now use the chosen unwinding settings.

Acknowledgment: not-matthias explicitly deferred bundled samply support and instructed that this PR wait for CodSpeedHQ/samply-codspeed#12. The known rejection of the new flags is not reported again.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A["run / exec flags and environment"] --> B["WalltimeRunArgs"]
  B --> C["resolve_unwinding_mode: new option wins"]
  B --> D["walltime_stack_sample_size"]
  C --> E["OrchestratorConfig"]
  D --> E
  E --> F["ExecutorConfig"]
  F --> G["perf: --call-graph"]
  F --> H["Linux samply: --unwinding-mode / --stack-size"]

Loading

_{Reviews (1) · Last reviewed commit: "feat(cli): add walltime unwinding mode a..." · Reviewed by Greptile}

[GuillaumeLagrange]

some few quirks to make sure we handle properly