Repository navigation
fix(liminal-drift): keep restart controls stationary - #35
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The post-merge Liminal Drift browser check failed because the end-screen's persistent positional animation kept the "Drive again" button moving, so Playwright's ordinary click could not find a stable target. See the failing main run.
Stop only the screen-tracking animation while the game status is
ended. Colored dropouts, interference and color effects continue; pause behavior is unchanged. Restart removes that state-specific rule and restores normal positional motion.Keep the original unforced one-click restart and interference-reset assertions. Add a regression that normal tracking animation resumes during the restarted run, and save the end-dialog screenshot alongside existing desktop/mobile browser artifacts. Update the README and Liminal's catalog timestamp.
Local formatting, JavaScript syntax and
git diff --checkpass. All four exact-head workflows and all four previews passed. Liminal browser integration confirmed the original unforced restart and motion-reset assertions; Apps & Packages, repository contract, and CodeQL passed. Desktop, mobile and end-dialog screenshots were inspected. The published tree70283f5f9d2fcba7a329a1a8f6ccee1eac73687dmatches locally reviewed signed commit8f1ee72f0639fe6cab01799352acf8b21b26ee3b. The branch starts at current main3b71575f50dab2b7a93a6aee934786fad62a26de.