Repository navigation
Remove withinSubjectExperimentSupportToggle and errorLogsToggle frontend env vars - #3406
Merged
Merged
Conversation
…end env vars Within Subjects is now always offered as a unit of assignment in the upsert experiment modal. errorLogsToggle had no remaining consumers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the removal of obsolete environment toggles and the availability of Within Subjects assignment across environments.
No open issues 🎉
What changed in this PR
Removes two obsolete frontend environment toggles and makes Within Subjects assignment available in the experiment modal across all environments.
Changes:
- Removes
withinSubjectExperimentSupportToggleand unusederrorLogsTogglefrom environment types and configuration files. - Adds Within Subjects directly to the assignment options, enabling it in production, BSNL, and demo.
- Removes the modal’s now-unneeded environment injection and conditional initialization.
| File | Description |
|---|---|
packages/frontend/projects/upgrade/src/environments/environment.ts |
Removes both toggles from default configuration. |
packages/frontend/projects/upgrade/src/environments/environment.staging.ts |
Removes both toggles from staging configuration. |
packages/frontend/projects/upgrade/src/environments/environment.qa.ts |
Removes both toggles from QA configuration. |
packages/frontend/projects/upgrade/src/environments/environment.prod.ts |
Removes both toggles from production configuration. |
packages/frontend/projects/upgrade/src/environments/environment.local.example.ts |
Updates the local configuration example. |
packages/frontend/projects/upgrade/src/environments/environment.demo.prod.ts |
Removes both toggles from demo configuration. |
packages/frontend/projects/upgrade/src/environments/environment.bsnl.ts |
Removes both toggles from BSNL configuration. |
packages/frontend/projects/upgrade/src/environments/environment-types.ts |
Removes toggle fields from build-time and runtime interfaces. |
packages/frontend/projects/upgrade/src/app/features/dashboard/experiments/modals/upsert-experiment-modal/upsert-experiment-modal.component.ts |
Always includes Within Subjects and removes environment-dependent initialization. |
Review effort: Balanced
danoswaltCL
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withinSubjectExperimentSupportToggleanderrorLogsTogglefields fromEnvironment,RuntimeEnvironmentConfig, and everyenvironment*.tsfile.UpsertExperimentModalComponent: Within Subjects is now part of theunitOfAssignmentsarray from the start, so it no longer gets pushed in the constructor based on the toggle. TheENVinjection was only there for this toggle, so it's removed too.errorLogsTogglehad no remaining consumers.Behavior change: prod, bsnl and demo will now show Within Subjects in the Unit of Assignment dropdown. Before, only staging and qa showed it.
Test plan
yarn workspace upgrade-frontend typecheck🤖 Generated with Claude Code