Repository navigation
fix(desktop-gpui): keep export progress steady during Turbo fallback - #3561
Open
yashranaway wants to merge 1 commit into
Open
yashranaway wants to merge 1 commit into
yashranaway wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Author
|
@greptileai review |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when a turbo export falls back to the normal exporter partway through, the fallback starts counting frames from zero again, so the export progress bar jumped backwards, e.g. from halfway to almost nothing.
now the progress callback keeps the highest frame count it has reported for that export and holds there until the fallback catches up. it's the one callback both file and link exports use, so neither ui needs its own guard.
This PR appears safe to merge.Summary
Keeps export progress from moving backward when Turbo falls back to the standard exporter.
Reviews (1) · Last reviewed commit: "fix(desktop-gpui): keep export progress ..." · Reviewed by Greptile