Repository navigation
fix(recording): preserve cursor hotspots when images match - #3560
Open
yashranaway wants to merge 1 commit into
Open
yashranaway wants to merge 1 commit into
yashranaway wants to merge 1 commit into
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when recording, we dedupe cursor images by their pixels only. but two cursors can look identical and have different hotspots (the point that actually clicks), so the second one reused the first cursor's id and got drawn with the wrong hotspot, putting the cursor in the wrong place in the recording.
now the hotspot is part of the cursor's identity, both for the "same as last image" shortcut and the hash we key saved cursors by. the bitmap hash used for recognising macos cursor shapes is unchanged.


Confidence Score: 5/5
The PR appears safe to merge.Summary
The PR keeps identical cursor images separate when their hotspots differ.
Reviews (1) · Last reviewed commit: "fix(recording): preserve cursor hotspots..." · Reviewed by Greptile