Skip to content

fix(recording): preserve cursor hotspots when images match - #3560

Open
yashranaway wants to merge 1 commit into
CapSoftware:mainfrom
yashranaway:fix/recording-cursor-hotspot
Open

yashranaway wants to merge 1 commit into
CapSoftware:mainfrom
yashranaway:fix/recording-cursor-hotspot

Conversation

@yashranaway

@yashranaway yashranaway commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

when recording, we dedupe cursor images by their pixels only. but two cursors can look identical and have different hotspots (the point that actually clicks), so the second one reused the first cursor's id and got drawn with the wrong hotspot, putting the cursor in the wrong place in the recording.

now the hotspot is part of the cursor's identity, both for the "same as last image" shortcut and the hash we key saved cursors by. the bitmap hash used for recognising macos cursor shapes is unchanged.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

The PR keeps identical cursor images separate when their hotspots differ.

  • Cursor IDs distinguish identical images with different hotspots.

Reviews (1) · Last reviewed commit: "fix(recording): preserve cursor hotspots..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant