Repository navigation
fix(web): preserve personal bucket lookup failures - #3558
Open
yashranaway wants to merge 1 commit into
Open
yashranaway wants to merge 1 commit into
yashranaway wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Author
|
@greptileai review |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if looking up a user's own s3 bucket settings failed (say a database error), we treated that the same as "no custom bucket" and quietly picked cap's default bucket. so someone who set up their own storage could have new uploads land in ours without knowing, which is exactly what they set up a bucket to avoid.
now the lookup error is passed through like the organization bucket lookup already does, so the request fails through the normal storage error path instead of switching destinations. no custom bucket at all still uses the default.
This PR appears safe to merge.Summary
Personal bucket lookup errors now reach the caller instead of silently selecting Cap storage.
Reviews (1) · Last reviewed commit: "fix(web): preserve personal bucket looku..." · Reviewed by Greptile