Repository navigation
fix(web): grant developer credit purchases once - #3557
Open
yashranaway wants to merge 1 commit into
Open
yashranaway wants to merge 1 commit into
yashranaway wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Author
|
@greptileai review |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
developer credit purchases could be granted twice. stripe can deliver the checkout completed and async payment succeeded events for the same purchase at nearly the same time, and the webhook's "already granted?" check ran outside any lock, so both deliveries saw nothing and both added the credits. one $25 top up became $50.
now the credit helper locks the account row and re-checks for that payment inside the same transaction before adding anything, so a second delivery just returns the current balance. no schema change, subscriptions untouched.
The PR appears safe to merge; the locked payment check closes the duplicate-grant race.Summary
The PR prevents concurrent Stripe deliveries from granting the same developer credit purchase twice.
Reviews (1) · Last reviewed commit: "fix(web): grant developer credit purchas..." · Reviewed by Greptile