Repository navigation
fix(web): preserve the original source for transcript backfills - #3556
Open
yashranaway wants to merge 1 commit into
Open
yashranaway wants to merge 1 commit into
yashranaway wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Author
|
@greptileai review |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when we backfill the editable transcript for an edited video, it's supposed to transcribe the preserved original, because the transcript describes the original timeline. but if that original couldn't be fetched, the source lookup quietly fell back to the edited mp4 and we saved the edited video's timestamps as if they were the original's, so words land in the wrong places.
now when an original source is given it's the only one we try. if it isn't reachable the backfill fails through the existing error path before calling the transcription provider or saving anything, so it can be retried. normal transcription still falls back like before.
The PR appears safe to merge.Summary
Edited-video transcript backfills now use only the preserved original when a source override is supplied.
Tests were inspected but not run.
Reviews (1) · Last reviewed commit: "fix(web): preserve the original source f..." · Reviewed by Greptile