Repository navigation
fix(web): process raw uploads completed with legacy file keys - #3555
Open
yashranaway wants to merge 1 commit into
Open
yashranaway wants to merge 1 commit into
yashranaway wants to merge 1 commit into
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multipart uploads still accept the old file key format, but when they did we threw away the part of the key after the video id. so completing a raw recording upload sent with an old key looked like a finished mp4: it skipped processing and skipped the check that all the raw parts arrived, leaving a video that never gets processed.
now the subpath is read from the old key the same way the key itself is parsed, so those uploads go through the normal raw upload flow. new style uploads are unchanged.
The PR appears safe to merge.Summary
Legacy multipart uploads now keep the subpath from
fileKey, so raw recordings reach the existing checks and processing flow.Reviews (1) · Last reviewed commit: "fix(web): process raw uploads completed ..." · Reviewed by Greptile