Repository navigation
fix(web): preserve domain verification when status checks fail - #3553
Open
yashranaway wants to merge 2 commits into
Open
yashranaway wants to merge 2 commits into
yashranaway wants to merge 2 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Author
|
@greptileai review |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checking a custom domain's status treated a failed lookup as "not verified". when the vercel api call errored, came back with an error response, or returned something unparseable, the check came back unverified with an error attached, and we cleared the org's domain verification, which turns off custom domain routing for an org whose dns was fine. the dialog also told them to fix their dns.
now a failed lookup throws before touching the database, so the dialog shows the existing "failed to check" message and verification stays as it was. a real misconfiguration still clears it.
The PR appears safe to merge, with no new actionable issues found.Summary
Preserves an organization's domain verification when a status lookup fails.
The previous unnumbered finding is addressed: provider JSON error bodies now reach the error check before the database write.
Reviews (2) · Last reviewed commit: "fix(web): treat Vercel error responses a..." · Reviewed by Greptile