Repository navigation
fix(web): report download link email delivery failures - #3552
Open
yashranaway wants to merge 1 commit into
Open
yashranaway wants to merge 1 commit into
yashranaway wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Author
|
@greptileai review |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the homepage "email me the download links" form always said the email was sent, even when it wasn't. the email helper hands back rejections (bad sender domain, email not configured, skipped) as a normal result instead of throwing, and the action only caught throws, so it reported success no matter what.
now the action only reports success when the provider actually accepted the email and gave back a message id, otherwise it shows the existing "something went wrong, try again" message. the shared helper is unchanged.
The PR appears safe to merge.Summary
The download-link action now reports failure when
sendEmailreturns no message data, instead of treating every completed call as success.Review was based on code inspection; tests were not run.
Reviews (1) · Last reviewed commit: "fix(web): report download link email del..." · Reviewed by Greptile