Repository navigation
fix(web): resolve legacy HLS playlist URIs on the server - #3551
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Member
Author
|
hey @greptileai, please re-review the PR |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older HLS recordings (
localandMediaConvertsources) on default storage now get a playlist from/api/playlistwhose URIs are absolute signed URLs, instead of a redirect to the stored.m3u8.sequenceDiagram participant P as Player participant A as /api/playlist participant S as Storage P->>A: GET ?videoType=master|video A->>S: read stream.m3u8 or output/video_recording_000.m3u8 opt multivariant playlist A->>S: read first rendition playlist end A-->>P: media playlist, every URI signed P->>S: segment_000.ts?Policy=...&Signature=...apps/web/app/api/playlist/route.ts:425). Comment and tag lines and absolute URIs pass through unchanged.MediaConvertmultivariant playlists carry a single rendition, so the first rendition is served directly rather than handing the player another relative child playlist.videoType=mp4still redirect to a signed URL, as before. Custom buckets and Instant segment playlists are untouched.apps/web/app/s/[videoId]/_components/HLSVideoPlayer.tsx:430).becomes


Confidence Score: 5/5
The changes since the previous review appear safe to merge.Summary
Legacy HLS playlists on default storage now return signed segment URLs instead of redirects.
Reviews (2) · Last reviewed commit: "fix(web): cap the URIs signed for one le..." · Reviewed by Greptile