feat(desktop-gpui): New Cap icon, Quick Look thumbnail and preview extensions by ItsEeleeya · Pull Request #3482 · CapSoftware/Cap

ItsEeleeya · 2026-10-27T15:53:49Z

This PR adds macOS Finder integration and branding for the GPUI app:

Quick Look thumbnails and previews for .cap packages, shipped as two signed extensions in Cap.app/Contents/PlugIns/.
Icon Composer icon for macOS 26+, compiled with actool into Assets.car. icon.icns remains as the fallback for older macOS.
Cap accent color via the bundle's AccentColor asset, which native controls pick up.

Changes

Quick Look (`apps/macos-bundles/`, `scripts/build-macos-bundles.mjs`)

A Swift package with two extension products. Each extension is its own bundle because an appex declares a single extension point.
Thumbnails use screenshots/display.jpg, or the screenshot image named in recording-meta.json (for screenshot packages, which store original.png).
Previews use output/result.mp4 when present, with the same image fallback.
Both share CapProject.swift for the lookup.
build-macos-bundles.mjs builds the products, assembles each .appex, and signs it with APPLE_SIGNING_IDENTITY and APPLE_KEYCHAIN, using hardened runtime, a timestamp, and the sandbox entitlements. CI fails without an identity. Local builds warn and produce unsigned bundles.
bundle-gpui.mjs places the signed bundles in PlugIns/ through macOS.files, before tauri bundle seals the app.
apps/desktop-gpui/Info.plist declares the so.cap.desktop.project UTI (conforms to com.apple.package, extension cap).

Icons and accent (`apps/desktop-gpui/icons/`, `scripts/build-macos-icon.mjs`)

cap-solarium.icon and Cap.xcassets are compiled with actool into Assets.car for release and debug bundles. The partial plist supplies CFBundleIconName and NSAccentColorName, which Info.plist also declares.
AccentColor is set to #007AFF (light) and #0A84FF (dark), matching the theme's accent values.
icon.icns is the legacy icon, and Windows and Linux use Sea Glass Icon (icon.png, icon.ico). build.rs and the NSIS installer icon point at these.
tauri.conf.json icon paths now point at icons/ in the GPUI app.
Updated Wix and NSIS installer images.

Debug build

bundle-gpui.mjs --profile=debug builds the GPUI binary without --release and bundles it. It refuses to run when CI is set.
The runtime Dock icon is set only under #[cfg(debug_assertions)], using assets/cap-debug-icon.png.
permission_guide.rs uses assets/app-icon.png (the Sea Glass art) for its in-window icon.

Testing

Manually verified on macOS:
- The debug bundle contains Assets.car, icon.icns, the CFBundleIconName / NSAccentColorName keys, and both extensions. It verifies with codesign --verify --deep --strict.
- Both extensions register from /Applications/Cap.app and are enabled.
- Recording and screenshot thumbnails and Quick Look previews work in Finder.
- The accent color and the Icon Composer icon appear as expected.
- The debug cargo run shows the debug Dock icon.

Notes for reviewers

Signing and notarization of the appex in CI is untested here. The local build cannot notarize because TAURI_SIGNING_PRIVATE_KEY isn't set.
Tauri CLI is 2.5.0 in apps/desktop. It can't read .icon or Assets.car from config, so the icon compile and the Assets.car placement are done by our scripts.

New Icons

The new icon has been adapted for macOS 26+ into cap-solarium.icon, and icon.icns for macOS 15 and earlier.
Original icon file provided by @richiemcilroy

Confidence Score: 4/5

Fix debug bundling on Windows and Linux and satisfy the required JSON formatting before merging.

Findings

Debug bundles use release files ▶
Icon tests never run ▶
Swift builds skip PR checks ▶
Asset JSON uses spaces ▶

Fix with agent prompt

### Issue 1
scripts/bundle-gpui.mjs:201
`--profile=debug` stages a debug binary on every platform, but only the macOS branch passes `--debug` to Tauri. On Windows or Linux, a local debug bundle therefore looks for the release binary instead. It fails if that binary is missing, or packages a release binary left from an earlier build. Forward `--debug` on those platforms too, or reject this option outside macOS.

### Issue 2
.github/workflows/ci.yml:369
Neither explicit test command includes the new `build-macos-icon.test.mjs`. The `gpui` filter also omits `scripts/build-macos-icon*`, so a later change limited to this helper will skip the desktop checks. Add the helper to the filter and its tests to both commands. Otherwise, a regression may first surface during a macOS release.

### Issue 3
.github/workflows/ci.yml:369
Pull request CI never compiles the new Swift products. `build-macos-bundles.test.mjs` checks text and JavaScript helpers; the remaining desktop steps run Rust tests. Only the release command reaches `swift build`, so a provider compile error can pass these checks and stop the next macOS release. Add an unsigned Swift build on the macOS jobs.

### Issue 4
apps/desktop-gpui/icons/Cap.xcassets/AccentColor.colorset/Contents.json:2-6
The new asset catalog JSON uses spaces for indentation. `AGENTS.md` requires tabs for new JSON files and says not to override that rule per file. Format this file and `Cap.xcassets/Contents.json` with tabs before merging to satisfy the repository requirement.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Adds macOS Quick Look extensions and updates Cap's icons and accent color.

Finder can show thumbnails and previews for Cap projects.
Cap’s desktop apps show the new Cap icon and macOS accent color.
Local GPUI debug bundles use a separate Dock icon.

ItsEeleeya explicitly described unsigned local extensions as intentional: local builds warn when no signing identity is supplied.

_{Reviews (1) · Last reviewed commit: "chore: exclude the Icon Composer source ..." · Reviewed by Greptile}

Ship two signed Quick Look extensions in Cap.app/Contents/PlugIns: thumbnails from screenshots/display.jpg (falling back to the screenshot image in recording-meta.json) and previews of output/result.mp4 with the same image fallback. Export the so.cap.desktop.project UTI so Finder matches .cap packages. scripts/build-macos-bundles.mjs compiles the Swift package and signs each appex with the app's identity before tauri bundle copies them in.

@objc

Check that each extension declares its own extension point and bundle id, that each principal class matches the @objc name its provider exports, that signing uses hardened runtime with the sandbox entitlements, and that signed appex are copied into PlugIns. Cover the opt-in --profile=debug path, which stays out of CI.

Compile icons/cap-solarium.icon and icons/Cap.xcassets with actool into Resources/Assets.car for release and debug bundles, and set CFBundleIconName, CFBundleIconFile (icon.icns), and NSAccentColorName in the GPUI Info.plist. Sea Glass drives the Windows and Linux icons. The runtime dock icon is debug-only and uses cap-debug-icon.png. Release never calls setApplicationIconImage, so macOS keeps the compiled icon's native layers.

Check the actool arguments for the Icon Composer file and asset catalog, the icon name and accent name parsed from actool's partial plist, using a fixture captured from real actool output.

vercel · 2026-10-27T15:53:59Z

@ItsEeleeya is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

greptile-apps · 2026-10-27T16:23:11Z

-		});
+		const result = await buildMacosPackages(
+			target,
+			[...bundleArgs, ...(profile === "debug" ? ["--debug"] : [])],


Debug bundles use release files

--profile=debug stages a debug binary on every platform, but only the macOS branch passes --debug to Tauri. On Windows or Linux, a local debug bundle therefore looks for the release binary instead. It fails if that binary is missing, or packages a release binary left from an earlier build. Forward --debug on those platforms too, or reject this option outside macOS.

Prompt To Fix With AI

This is a comment left during a code review. Path: scripts/bundle-gpui.mjs Line: 201 Comment: **Debug bundles use release files** `--profile=debug` stages a debug binary on every platform, but only the macOS branch passes `--debug` to Tauri. On Windows or Linux, a local debug bundle therefore looks for the release binary instead. It fails if that binary is missing, or packages a release binary left from an earlier build. Forward `--debug` on those platforms too, or reject this option outside macOS. --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

greptile-apps · 2026-10-27T16:23:11Z


      - name: Test desktop build preparation
-        run: node --test scripts/prepare-gpui-dependency.test.mjs scripts/build-macos-packages.test.mjs scripts/bundle-gpui.test.mjs scripts/finalize-macos-packages.test.mjs
+        run: node --test scripts/prepare-gpui-dependency.test.mjs scripts/build-macos-packages.test.mjs scripts/bundle-gpui.test.mjs scripts/build-macos-bundles.test.mjs scripts/finalize-macos-packages.test.mjs


Icon tests never run

Neither explicit test command includes the new build-macos-icon.test.mjs. The gpui filter also omits scripts/build-macos-icon*, so a later change limited to this helper will skip the desktop checks. Add the helper to the filter and its tests to both commands. Otherwise, a regression may first surface during a macOS release.

Knowledge Base Used: Build and release automation

Prompt To Fix With AI

This is a comment left during a code review. Path: .github/workflows/ci.yml Line: 369 Comment: **Icon tests never run** Neither explicit test command includes the new `build-macos-icon.test.mjs`. The `gpui` filter also omits `scripts/build-macos-icon*`, so a later change limited to this helper will skip the desktop checks. Add the helper to the filter and its tests to both commands. Otherwise, a regression may first surface during a macOS release. **Knowledge Base Used:** [Build and release automation](https://app.greptile.com/cap/-/custom-context/knowledge-base/capsoftware/cap/-/docs/build-and-release-automation.md) --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

greptile-apps · 2026-10-27T16:23:11Z


      - name: Test desktop build preparation
-        run: node --test scripts/prepare-gpui-dependency.test.mjs scripts/build-macos-packages.test.mjs scripts/bundle-gpui.test.mjs scripts/finalize-macos-packages.test.mjs
+        run: node --test scripts/prepare-gpui-dependency.test.mjs scripts/build-macos-packages.test.mjs scripts/bundle-gpui.test.mjs scripts/build-macos-bundles.test.mjs scripts/finalize-macos-packages.test.mjs


Swift builds skip PR checks

Pull request CI never compiles the new Swift products. build-macos-bundles.test.mjs checks text and JavaScript helpers; the remaining desktop steps run Rust tests. Only the release command reaches swift build, so a provider compile error can pass these checks and stop the next macOS release. Add an unsigned Swift build on the macOS jobs.

Prompt To Fix With AI

This is a comment left during a code review. Path: .github/workflows/ci.yml Line: 369 Comment: **Swift builds skip PR checks** Pull request CI never compiles the new Swift products. `build-macos-bundles.test.mjs` checks text and JavaScript helpers; the remaining desktop steps run Rust tests. Only the release command reaches `swift build`, so a provider compile error can pass these checks and stop the next macOS release. Add an unsigned Swift build on the macOS jobs. --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

greptile-apps · 2026-10-27T16:23:11Z

+  "colors" : [
+    {
+      "color" : {
+        "color-space" : "srgb",
+        "components" : {


Asset JSON uses spaces

The new asset catalog JSON uses spaces for indentation. AGENTS.md requires tabs for new JSON files and says not to override that rule per file. Format this file and Cap.xcassets/Contents.json with tabs before merging to satisfy the repository requirement.

Context Used: AGENTS.md (source)

Prompt To Fix With AI

This is a comment left during a code review. Path: apps/desktop-gpui/icons/Cap.xcassets/AccentColor.colorset/Contents.json Line: 2-6 Comment: **Asset JSON uses spaces** The new asset catalog JSON uses spaces for indentation. `AGENTS.md` requires tabs for new JSON files and says not to override that rule per file. Format this file and `Cap.xcassets/Contents.json` with tabs before merging to satisfy the repository requirement. **Context Used:** AGENTS.md ([source](https://github.com/capsoftware/cap/blob/main/AGENTS.md)) --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

…in CI Pass --debug to tauri bundle on every platform, not only macOS, so a local debug bundle never packages a release binary. Run the icon helper tests in the desktop checks and the desktop-gpui path filter, and compile the Swift Quick Look products on the macOS jobs. Format the Cap.xcassets catalogs with tabs.

Regenerate the legacy icon.icns from the 1024px legacy PNG, and add the legacy dev icon used by debug builds on macOS before 26.

Debug builds use the current dev icon on macOS 26 and later, and the legacy dev icon on older systems. Release builds never set a runtime icon.

Gate set_dock_icon and its stubs with cfg(debug_assertions), matching the call site in main.rs. Release bundles take their icon from Assets.car and never set a runtime image, which would replace the native layers.

…the Icon Composer source Generate icon.icns for macOS before 26, the Windows and Linux PNGs, and icon.ico from cap-glass-icon.png. Use the same image as the dock icon. Sync cap-solarium.icon to the updated Icon Composer source. Ignore Icon Composer sources in Biome with a plain *.icon pattern, since Biome 2.2 flags a trailing /** on a folder ignore.

Take upstream's move of the GPUI resources off the Tauri tree and its removal of apps/desktop. Keep the Quick Look bundles, the Icon Composer and accent wiring, and the debug profile on top of that layout. Use the glass icon for the dock icon and the legacy, Windows, and Linux icons, and keep the GPUI bundle config's icon list pointing at icons/.

buildMacosPackages sends its own --config, so the platform file written by bundle-gpui never reached the bundler and PlugIns and Assets.car were dropped. Accept a platformConfig option and pass it as a second --config. A regression test pins the extra layer.

Use upstream's set_dock_icon, and gate only its call site in debug builds. Restore upstream's NSIS sidebar image and keep the icon list pointing at icons/icon.icns, icons/icon.ico and icons/icon.png.

ItsEeleeya added 5 commits October 27, 2026 14:13

test(desktop-gpui): cover the actool icon and accent wiring

d09e309

Check the actool arguments for the Icon Composer file and asset catalog, the icon name and accent name parsed from actool's partial plist, using a fixture captured from real actool output.

New wix and installer images based on the new icons and theme

f6f86f9

chore: exclude the Icon Composer source from Biome

7665382

ItsEeleeya marked this pull request as ready for review October 27, 2026 16:18

greptile-apps Bot reviewed Oct 27, 2026

View reviewed changes

ItsEeleeya added 15 commits October 27, 2026 20:10

test(desktop-gpui): pin the debug profile arguments for every platform

a409de4

fix(wix-installer image): use proper name

4ab694d

update Sea Glass Icon

050b628

chore(desktop-gpui): ship the updated macOS legacy and dev icons

7439810

Regenerate the legacy icon.icns from the 1024px legacy PNG, and add the legacy dev icon used by debug builds on macOS before 26.

feat(desktop-gpui): pick the debug dock icon by macOS version

a6b846a

Debug builds use the current dev icon on macOS 26 and later, and the legacy dev icon on older systems. Release builds never set a runtime icon.

Updated cap-solarium.icon: use the sea glass style

455eb7c

Merge remote-tracking branch 'upstream/main' into macos-extra-bundles

e02ce29

Merge remote-tracking branch 'upstream/main' into macos-extra-bundles

7a3c651

fix(desktop-gpui): only set the dock icon in debug builds

1c44e97

Gate set_dock_icon and its stubs with cfg(debug_assertions), matching the call site in main.rs. Release bundles take their icon from Assets.car and never set a runtime image, which would replace the native layers.

Update icon shadow

25fc1a7

chore(desktop-gpui): match upstream outside the icon and debug changes

96378cc

Use upstream's set_dock_icon, and gate only its call site in debug builds. Restore upstream's NSIS sidebar image and keep the icon list pointing at icons/icon.icns, icons/icon.ico and icons/icon.png.

Navigation Menu

Repository navigation

feat(desktop-gpui): New Cap icon, Quick Look thumbnail and preview extensions - #3482

feat(desktop-gpui): New Cap icon, Quick Look thumbnail and preview extensions#3482
ItsEeleeya wants to merge 21 commits into
CapSoftware:mainfrom
ItsEeleeya:macos-extra-bundles

ItsEeleeya commented Oct 27, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Oct 27, 2026

Uh oh!

greptile-apps Bot Oct 27, 2026

Uh oh!

greptile-apps Bot Oct 27, 2026

Uh oh!

greptile-apps Bot Oct 27, 2026

Uh oh!

greptile-apps Bot Oct 27, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

ItsEeleeya commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Quick Look (apps/macos-bundles/, scripts/build-macos-bundles.mjs)

Icons and accent (apps/desktop-gpui/icons/, scripts/build-macos-icon.mjs)

Debug build

Testing

Notes for reviewers

New Icons

Confidence Score: 4/5

Findings

Summary

Uh oh!

vercel Bot commented Oct 27, 2026

Uh oh!

greptile-apps Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ItsEeleeya commented Oct 27, 2026 •

edited

Loading

Quick Look (`apps/macos-bundles/`, `scripts/build-macos-bundles.mjs`)

Icons and accent (`apps/desktop-gpui/icons/`, `scripts/build-macos-icon.mjs`)