Skip to content

feat: add extended-key slot-2 signer for safes - #9984

Merged
pranishnepal merged 1 commit into
masterfrom
WCN-2895
Oct 16, 2026
Merged

pranishnepal merged 1 commit into
masterfrom
WCN-2895

Conversation

@pranishnepal

Copy link
Copy Markdown
Contributor

What

For safes, add signEd25519Extended to sign directly from a soft-derived BIP32-Ed25519 extended key (scalar kL + nonce prefix kR), which has no seed and so cannot use seed-based signers.

Add an optional externalBackupSignature to XLM/HBAR/ALGO recover() so the backup child's signature can be injected instead of signed from a seed.

TICKET: WCN-2895

For safes, Add signEd25519Extended to sign directly from a soft-derived
BIP32-Ed25519 extended key (scalar kL + nonce prefix kR), which has no
seed and so cannot use seed-based signers.

Add an optional externalBackupSignature to XLM/HBAR/ALGO recover() so
the backup child's signature can be injected instead of signed from a
seed.

Ticket: WCN-2895
@linear-code

linear-code Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

WCN-2895

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Unit tests are failing on Node 26.x (Current release line, non-blocking). This is not an LTS version yet, so it does not block merge, but it signals an incompatibility to fix before Node 26.x becomes LTS.

View run

@pranishnepal
pranishnepal marked this pull request as ready for review October 15, 2026 21:25
@pranishnepal
pranishnepal requested review from a team as code owners October 15, 2026 21:25
@davidkaplanbitgo

Copy link
Copy Markdown
Contributor

@claude

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @davidkaplanbitgo's task —— View job


I'll analyze this and get back to you.

@Venkat-Annavazzala Venkat-Annavazzala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pranishnepal
pranishnepal merged commit 8740b1c into master Oct 16, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants