Skip to content

feat: add slot-2 safe recovery derivation - #9976

Merged
pranishnepal merged 1 commit into
masterfrom
WCN-2894
Oct 14, 2026
Merged

pranishnepal merged 1 commit into
masterfrom
WCN-2894

Conversation

@pranishnepal

Copy link
Copy Markdown
Contributor

What

Adds the ed25519Multisig (slot 2) work to deriveSafeWalletKeys so offline Safe recovery can derive ALGO/XLM/HBAR wallet keys, plus the pure codecs and encoders it needs.

  • sdk-lib-safes: decodeEd25519ChainCode, encodeEd25519StrKeySecretSeed, encodeAlgoKey, and HBAR DER encoders
  • sdk-lib-safes: deriveSafeChildEd25519HardenedAtPath
  • sdk-core: softDeriveChildPubEd25519AtPath and softDeriveChildPrvEd25519AtPath
  • sdk-core: ed25519Multisig arm + SafeEd25519SeedKey/SafeEd25519ExtendedKey typed shapes (kind: seed | extended)

The user child derives hardened at m/44'/coinType'/2'/account'; backup and bitgo soft at m/44/coinType/2/account from seed+chainCode and the composite pub respectively.

Ticket: WCN-2894

@linear-code

linear-code Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

WCN-2894

@pranishnepal
pranishnepal marked this pull request as ready for review October 14, 2026 16:42
@pranishnepal
pranishnepal requested review from a team as code owners October 14, 2026 16:42
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ Unit tests are failing on Node 26.x (Current release line, non-blocking). This is not an LTS version yet, so it does not block merge, but it signals an incompatibility to fix before Node 26.x becomes LTS.

View run

Adds the ed25519Multisig (slot 2) arm to deriveSafeWalletKeys so offline
Safe recovery can derive ALGO/XLM/HBAR wallet keys, plus the pure codecs
and encoders it needs.

- sdk-lib-safes: decodeEd25519ChainCode, encodeEd25519StrKeySecretSeed,
                 encodeAlgoKey, and HBAR DER encoders
- sdk-lib-safes: deriveSafeChildEd25519HardenedAtPath
- sdk-core: softDeriveChildPubEd25519AtPath and
            softDeriveChildPrvEd25519AtPath
- sdk-core: ed25519Multisig arm +
            SafeEd25519SeedKey/SafeEd25519ExtendedKey
            typed shapes (kind: seed | extended)

The user child derives hardened at m/44'/coinType'/2'/account'; backup
and bitgo soft at m/44/coinType/2/account from seed+chainCode and the
composite pub respectively.

Ticket: WCN-2894

@danielpeng1 danielpeng1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pranishnepal
pranishnepal merged commit 58eebd2 into master Oct 14, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants