Repository navigation
feat: carry ed25519 backup chain code on keycard - #9957
Merged
Merged
Conversation
Contributor
Contributor
|
|
pranishnepal
marked this pull request as ready for review
October 13, 2026 19:30
pranishnepal
requested review from
kisslove-dewangan and
mohammadalfaiyazbitgo
October 13, 2026 19:30
davidkaplanbitgo
previously approved these changes
Oct 13, 2026
s84krish
previously approved these changes
Oct 13, 2026
s84krish
left a comment
s84krish
left a comment
Contributor
There was a problem hiding this comment.
lgtm, conflicts though :(
pranishnepal
dismissed stale reviews from s84krish and davidkaplanbitgo
via
October 13, 2026 21:52
b1ccd13
pranishnepal
force-pushed
the
WCN-2893
branch
from
October 13, 2026 21:52
8a26d69 to
b1ccd13
Compare
danielpeng1
approved these changes
Oct 13, 2026
davidkaplanbitgo
approved these changes
Oct 14, 2026
Box B's ed25519Multisig entry now stores {prv, chainCode} instead of a
bare encrypted seed. The chain code is extracted from the backup root's
composite pub and encoded as 52-char canonical base32. Other slots and
boxes A/C remain bare strings.
We need to add `chaincode` to facilitate the recovery of these wallets
Ticket: WCN-2893
pranishnepal
force-pushed
the
WCN-2893
branch
from
October 14, 2026 01:30
b1ccd13 to
a2cc78e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Box B's ed25519Multisig entry now stores {prv, chainCode} instead of a bare encrypted seed. The chain code is extracted from the backup root's composite pub and encoded as 52-char canonical base32. Other slots and boxes A/C remain bare strings.
We need to add
chaincodeto facilitate the recovery of these wallets.Ticket: WCN-2893