Repository navigation
fix: keep configureAccount on enableToken intents (CHALO-1883) - #10128
Merged
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
Contributor
|
|
at31416
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
populateIntentdropped theconfigureAccountopt-in for non-EVM enableToken prebuilds: thegeneric tail only copied the flag inside its
feeOptions !== undefinedbranch, and the SolanaenableTokenprebuild supplies no feeOptions — sowallet.enableToken({ configureAccount: true })reached Wallet Platform with the flag silently dropped and routed to plain ATA-init instead of
ConfigureAccount (found in wallet-platform PR #63702 review, which had flagged this against the
pinned beta).
Changes
mpcUtils.ts: the generic tail now carriesconfigureAccountforenableTokenintentsregardless of feeOptions, scoped to that intent so other intents gain no field.
mpcUtils.enableToken.ts: 4 new unit tests — opt-in without feeOptions, explicit opt-out,opt-in with feeOptions, and no-field-for-non-enableToken intents (red/green proven: the two
no-feeOptions cases failed against the prior code).
Refs: CHALO-1883