Repository navigation
Validate dependency baseline and isolated Python 3.14 builds - #71
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
mtinning
approved these changes
Oct 20, 2026
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Publishing workflow changes remain unverified in CircleCI and require final maintainer review.
No open issues 🎉
What changed in this PR
Updates dependency and packaging baselines for Python 3.14, addressing #70 while preserving optional PyQt5 support and production APIs.
Changes:
- Adds patched dependency minimums and isolated builds.
- Restores seven task-runner tests and tests the installed wheel outside the checkout.
- Expands CI artifact checks and documents validation results and limitations.
| File | Description |
|---|---|
| tox.ini | Tests installed wheels and restores task-runner coverage. |
| tests/services/test_task_runner.py | Uses thread-safe gates and bounded Qt waits. |
| setup.py | Updates dependency floors and packaging extras. |
| README.md | Documents development and packaging commands. |
| pyproject.toml | Declares the isolated setuptools backend. |
| docs/dependency-validation.md | Records validation evidence and remaining limits. |
| docs/dependency-candidate.txt | Records updated dependency versions. |
| docs/dependency-baseline.txt | Records baseline dependency versions. |
| .circleci/config.yml | Builds and checks wheels and source distributions. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set patched dependency/build minimums and make Python 3.14 packaging and test coverage explicit. The base package keeps PyQt5 optional; the already-merged script-runner/Python 3.14 changes remain intact.
Fixes #70.
Validation on Linux x86_64 / Python 3.14.6 at commit 5d28e2f:
python -m tox -e py314: 79 passed, including task-runner and existing script-runner regressions; license-header checker passed. Installed-wheel statement coverage is 30%, not exhaustive coverage.pip checkpassed.python -m buildandpython -m twine check --strict: wheel and sdist passed. Both install in separate clean base/UI environments (four passing installs), withpip check, outside-checkout metadata/import checks, recursive script/template/data smoke tests and offscreen Qt initialization. Both base environments have no PyQt5.git diff --checkpassed; no repository pre-commit configuration is present. No UI behavior changed, so visual evidence is not applicable.Final local artifact SHA256:
Windows/macOS, other architectures/Python versions, interactive rendering and actual CircleCI execution remain unverified here. The dependency ranges remain open and need future revalidation; source review does not establish a hostile-script/template sandbox or comprehensive native/widget security coverage. Keep this PR draft for maintainer review. Tagging, publication and merging remain maintainer actions; none was performed.