Skip to content

style(lint): Remove unused nolint statement - #5

Merged
simonnix merged 1 commit into
mainfrom
style/fix-nolint
Oct 28, 2026
Merged

simonnix merged 1 commit into
mainfrom
style/fix-nolint

Conversation

@simonnix

@simonnix simonnix commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Made a minor internal maintenance change. No user-facing behavior or functionality changed.

@simonnix simonnix self-assigned this Oct 28, 2026
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 158aab81-fead-4535-9d43-c20a93d3780c
Commits

Reviewing files that changed from the base of the PR and between b7e3101 and 0f3b6e7.

Files selected for processing: 1
  • pkg/core/query_builder.go
Files with no reviewable changes: 1
  • pkg/core/query_builder.go

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

Walkthrough

The change removes the nolint:errcheck comment before opt.SetValue(&t) in the query builder. The call and its conditional path remain unchanged.

Changes: Query builder lint annotation

Layer / File(s) Summary
Remove errcheck suppression
pkg/core/query_builder.go
The nolint:errcheck comment before opt.SetValue(&t) is removed. The call and its conditional path are unchanged.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: Minimal · up to 0f3b6

No actionable merge risk is identified; this change is mergeable after normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately and concisely describes the removal of the unused nolint statement, which is the only change in the pull request.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@simonnix
simonnix merged commit 7e266f6 into main Oct 28, 2026
3 checks passed
@simonnix
simonnix deleted the style/fix-nolint branch October 28, 2026 17:01
@codecov

codecov Bot commented Oct 28, 2026

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant